Re: [PATCH] Constify. (fwd)

[Tamas TEVESZ]

On Tue, 16 Mar 2010, Tamas TEVESZ wrote:

 > carlos, final dirhier item i realized after having some sleep. i'll 
 > let this go now ;)

surprise!! i lied ;)

i dug into the logging stuff (stay tuned), and it turns out message 
should rather be formatted as follows.

>From 84ff79301ac2586dfdfbef075f0e245435f1dfe7 Mon Sep 17 00:00:00 2001
From: Tamas TEVESZ <i...@extreme.hu>
Date: Wed, 17 Mar 2010 02:31:28 +0100
Subject: [PATCH] Fix log string

---
 WINGs/proplist.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/WINGs/proplist.c b/WINGs/proplist.c
index 92c388a..fe26661 100644
--- a/WINGs/proplist.c
+++ b/WINGs/proplist.c
@@ -1681,7 +1681,7 @@ static int WMMkDirHier(const char *path)
                strncpy(buf, thePath, p);
                if (mkdir(buf, 0777) == -1 && errno == EEXIST &&
                    stat(buf, &st) == 0 && !S_ISDIR(st.st_mode)) {
-                       wsyserror(_("Could not create component %s: "), buf);
+                       wsyserror(_("Could not create component %s"), buf);
                        wfree(thePath);
                        return 0;
                }
-- 
1.7.0




-- 
[-]

mkdir /nonexistent
From 84ff79301ac2586dfdfbef075f0e245435f1dfe7 Mon Sep 17 00:00:00 2001
From: Tamas TEVESZ <i...@extreme.hu>
Date: Wed, 17 Mar 2010 02:31:28 +0100
Subject: [PATCH] Fix log string

---
 WINGs/proplist.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/WINGs/proplist.c b/WINGs/proplist.c
index 92c388a..fe26661 100644
--- a/WINGs/proplist.c
+++ b/WINGs/proplist.c
@@ -1681,7 +1681,7 @@ static int WMMkDirHier(const char *path)
 		strncpy(buf, thePath, p);
 		if (mkdir(buf, 0777) == -1 && errno == EEXIST &&
 		    stat(buf, &st) == 0 && !S_ISDIR(st.st_mode)) {
-			wsyserror(_("Could not create component %s: "), buf);
+			wsyserror(_("Could not create component %s"), buf);
 			wfree(thePath);
 			return 0;
 		}
-- 
1.7.0