On Tue, 23 Mar 2010, Carlos R. Mafra wrote:

 > On Mon, 22 Mar 2010 at 15:53:47 +0100, Tamas TEVESZ wrote:
 > >
 > > +
 > > +#if defined( FREEBSD ) || defined( DRAGONFLYBSD )
 > 
 > [...]
 > 
 > > +#if defined( OPENBSD )
 > 
 > Why not rely on gcc definitions like
 > 
 > #ifdef __FreeBSD__
 > #ifdef __OpenBSD__
 > #ifdef __DragonFly__
 > #ifdef __linux__
 > 
 > In this way there would be no need to define FREEBSD etc in the configure.ac 
 > stuff, which I think will be needed here, right? Or am I missing something? 
 > (which is probably the case)

fine with me. i just put them in as sort of "markers", so when 
autostuff is done, it can be changed accordingly.

note however that it is not certain every compiler defines these 
defines (wooha, watch this!), but considering we are a decade away 
from a clean codebase, and this a small and isolated piece, i don't 
really mind about that now.


-- 
[-]

mkdir /nonexistent


-- 
To unsubscribe, send mail to [email protected].

Reply via email to