On Sat, 11 Sep 2010 at 21:58:13 +0400, Alexey I. Froloff wrote: > On Sat, Sep 11, 2010 at 05:42:04PM +0200, Carlos R. Mafra wrote: > > You need the patch below to see the highlighting --- which is cool > > and now it will be the default in wmaker-crm. > If you define NEWAPPICON in wconfig.h, you can't disable it > without hacking headers, which is not good.
But that's how a lot of things are done now. And I don't think it's that bad. The idea is more or less "what is nice to have enabled by default, does not make sense to add a configure option in WPrefs and can still be compiled out if someone has a strong feeling against it to the point of wanting the sources to look how to remove it". > We can either have > configure option (this can be easily enabled/disabled and change > its default setting) A configure option is not apropriate in this case. It should be used for rather upper-level stuff like "xinerama" or "modelock". Using a configure option to decide whether to use animation for some icon is too much, IMHO. > For this patch I can imagine things like "highlite level", > "darkening" hidden/minimized appicons along with "darken level", > even "hilite color"... Right, in fact I think the current "highlight level" is not too visible if one is not paying too much attention. But again, I am all for sensible default values. Having configurable options for everything is not what I want to do. -- To unsubscribe, send mail to [email protected].
