On Fri, 8 Oct 2010 at 15:08:29 -0400, Brad Jorsch wrote: > This is my attempt to clean up the handling of NET_WM_ICON and the > "black and white icons" issue. > > Patch 1 fixes some miscellaneous compiler warnings I came across in the > course of creating this patch series. "make CFLAGS='-g -O2 -Werror'" > should compile after all are applied. > > Patch 2 fixes the logic of handling NET_WM_ICON. We weren't even > watching the right place to detect an app's changes to the property, nor > were we actually updating the icon if we did happen to notice. > > Patch 3 fixes the logic in wIconUpdate to use net_wm_icon correctly, > instead of only checking it at icon creation time. > > Patch 4 adds calls to wAppIconPaint after wIconUpdate where necessary, > so non-shared appicons can be changed by the app. > > Patch 5 is my go at the related issue of caching icons only when we > really need to (i.e. when the app is docked). > > Shared appicons still don't react to app changes. The problem there is > that there are potentially many different leader windows that might be > specifying different icons, and it doesn't seem worth the trouble to > propagate icon changes from just one of those leaders.
Thanks a lot for solving this, Brad! As Tamas once said, you should be cast in gold. The patches look fine. I did some testing already and they survived my test cases. Thanks again! PS: I fixed patch 4/5 as you pointed out. -- To unsubscribe, send mail to [email protected].
