On 04.03.2012 19:19 (UTC+1), Doug Barton wrote:
On 03/04/2012 03:48, Rainer Hurling wrote:
So there is no 'norestore: (null)' any more.

Ok.

Update my last posting: The output from src/startup.c:766 only happens,
when I set

   if (!wPreferences.flags.restarting) { ... }

instead of

   if (wPreferences.flags.restarting == 0&&
!wPreferences.flags.norestore) { ... }

/usr/local/bin/wmaker(StartUp(startup.c:766)): norestore: 0

Well the debug output pretty clearly shows that the values are being set
properly, but that's not being recognized unless the test is logical
negation instead of '== 0'. I don't have an explanation for that, I'll
try to write up something to go out to our C experts in the next couple
days.

Meanwhile I restored this change in our port. Once your local repo sees
PORTREVISION= 2 try it again and see if the port works for you.

Thanks for patching the port again. Unfortunately it does not work in my case for two boxes. I list it here for people not using FreeBSD:


--- src/startup.c.bak   2012-02-14 20:36:01.000000000 +0100
+++ src/startup.c       2012-03-05 17:28:59.000000000 +0100
@@ -761,7 +761,7 @@
                wMenuRestoreState(wScreen[j]);

                /* If we're not restarting, restore session */
- if (wPreferences.flags.restarting == 0 && !wPreferences.flags.norestore) + if (!wPreferences.flags.restarting && !wPreferences.flags.norestore)
                        wSessionRestoreState(wScreen[j]);

                if (!wPreferences.flags.noautolaunch) {

@${REINPLACE_CMD} -e "764s#wPreferences.flags.restarting == 0#!wPreferences.flags.restarting#" \
            ${WRKSRC}/src/startup.c


I am sorry, but obviously I had been a bit imprecise about that patch. I did not list it on the table in posting from 2012-02-27 21:55 (news://news.gmane.org:119/[email protected]). This patch does _not_ work for the first and the third box, but does for the second.

As I wrote at freebsd-ports@ (2012-02-22 19:47) restoring sessions mostly works for me, if at least one of both terms from line 764 is commented out (called 'random'). Restoring always works, when I delete line 764 completely.

That is very confusing for me,
Rainer


Thanks,

Doug



--
To unsubscribe, send mail to [email protected].

Reply via email to