On Tue, 19 Jun 2012, Alexey I. Froloff wrote:
https://github.com/raorn/wdm (ALT patches mostly).  Right now I
am cleaning up the autocrap stuff, next step is to reindent the
code and drop all non-linux support.

After looking at the code I see a potential problem with this approach. Most of the stuff you intend to clean up comes from xdm. According to the README it's based on xdm from XFree86 4.2.1.1. This is quite a few years old and probably have evolved and been fixed in a few places since. If you do the clean up first then it will diverge from xdm more and it becomes more difficult to find and merge the fixes from the newer xdm versions.

A better approach may be to identify the differences between the original xdm version and wdm (the 4.2.1.1 version xdm can be found in XFree86's CVS here: http://cvsweb.xfree86.org/cvsweb/xc/programs/xdm/?only_with_tag=xf-4_2_1_1) and then try to redo this with a newer xdm (maybe from xorg). Otherwise you'll have to check for fixes in your cleaned up xdm code which now does not really resemble the original and try to merge them to be in line with current xdm. In other words, by doing the clean up you diverge from xdm and cannot benefit from fixes they do that easily so you'll be on your own to keep wdm updated. Does this worth the effort? (It may worth it if the code becomes so simple that it's easy to maintain.)

Regards,
BALATON Zoltan


--
To unsubscribe, send mail to [email protected].

Reply via email to