On Wed, 3 Apr 2013 at 13:01:03 +0300, Gabriel VLASIU wrote:
>
> Attached are 5 patches which fix almost all compilation warnings.
Thanks for the patches.
But have you thought about using 'git' to generate them?
You wrote 5 patches, so it's a bit of overhead for me to apply them individually
and for each one of them create the appropriate header in order to have
you as the author.
I can do that now, but it wastes my time. So if you think about writing
other patches I would really appreciate if you could send them as
the result of 'git format-patch'.
One comment:
> --- wmbiff/wmbiff/tlsComm.c.OLD 2013-04-01 15:26:07.000000000 +0300
> +++ wmbiff/wmbiff/tlsComm.c 2013-04-03 12:50:57.201128287 +0300
> @@ -124,7 +124,7 @@
> @@ -295,6 +295,7 @@
> va_list args;
> char buf[1024];
> int bytes;
> + ssize_t unused __attribute__((unused));
>
> if (scs == NULL) {
> DMA(DEBUG_ERROR, "null connection to tlscomm_printf\n");
> @@ -316,7 +317,8 @@
> }
> } else
> #endif
> - (void) write(scs->sd, buf, bytes);
> + /* Why???? */
> + unused = write(scs->sd, buf, bytes);
> } else {
> printf
> ("warning: tlscomm_printf called with an invalid socket
> descriptor\n");
Wouldn't it be better to simply check if the write() was successful and
avoid the articial 'unused' workaround?
--
To unsubscribe, send mail to [email protected].
