On Sat, 11 Feb 2012 at 21:16:34 +0000, Carlos R. Mafra wrote:
>
> Subject: [PATCH] clip: Do not display balloon with workspace name
Oh, I see now.
This balloon can be slightly useful if the clip is already displaying
the workspace name. If the name does not fit into the clip icon it is
drastically cut at the boundary, and then moving the mouse over the
clip "completes" the name by writing the missing piece -- which is
the odd thing I saw earlier, and it is odd because my clip was not
displaying the workspace name.
So another less disrupting option would be to display the balloon
only if show_clip_title is set via WPrefs, something like the patch
below.
But I find this behavior of completing the name a workaround for
a ugly situation. Having the name cut does not look beautiful, and
I see little aesthetic improvement by completing it like that.
Does anybody who hasn't already shortened the workspace name
like this balloon completion? I think the code removal for this
dubious situation is better than the patch below. And perhaps
another patch to not display a name which does not fit would
also be appropriate.
Comments?
diff --git a/src/dock.c b/src/dock.c
index 0928320..b4161e7 100644
--- a/src/dock.c
+++ b/src/dock.c
@@ -3825,6 +3825,9 @@ static void showClipBalloon(WDock * dock, int workspace)
char *text;
Window stack[2];
+ if (!wPreferences.show_clip_title)
+ return;
+
scr->flags.clip_balloon_mapped = 1;
XMapWindow(dpy, scr->clip_balloon);
--
To unsubscribe, send mail to [email protected].
