Ok

the value "0" cannot be used :-?

kix@osaka:~/src/wmaker-crm/src$ git diff
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index 31a497b..c9bfe40 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -28,14 +28,14 @@
 
 /* class codes */
 typedef enum {
-    WCLASS_WINDOW = 0,         /* Window contents */
-    WCLASS_MENU = 1,           /* Menus */
-    WCLASS_APPICON = 2,                /* Application Icon &
+    WCLASS_WINDOW = 1,         /* Window contents */
+    WCLASS_MENU = 2,           /* Menus */
+    WCLASS_APPICON = 3,                /* Application Icon &
                                 * dockeable application outside
                                 * the clip/dock */
-    WCLASS_MINIWINDOW = 3,     /* Application minimized */
-    WCLASS_DOCK_ICON = 4,      /* Dock, clip, dockeable app docked */
-    WCLASS_FRAME = 5           /* Window Frame (title, border,... */
+    WCLASS_MINIWINDOW = 4,     /* Application minimized */
+    WCLASS_DOCK_ICON = 5,      /* Dock, clip, dockeable app docked */
+    WCLASS_FRAME = 6           /* Window Frame (title, border,... */
 } WClassType;
 
 /*
kix@osaka:~/src/wmaker-crm/src$

But why? Yes, is zero, zero is different, but I cannot find where the problem 
is.

kix

On Mon, 02 Apr 2012, Rodolfo kix Garcia escribió:

> This is incredible...
> 
> one more time, don't apply this patch... incredible.
> 
> The reason, is, if you apply the patch, all works fine, but, if you make 
> right click on a docked application, then click in "Launch" when te 
> application is already launched, then, WindowMaker restarts.
> 
> Please, don't ask how I found the bug.
> 
> I will try to find the problem (hardcoded type in the code??).
> 
> Regards,
> kix
> 
> On Mon, 02 Apr 2012, Rodolfo kix Garcia escribió:
> 
> > 
> > From b4d2de26ef2588c62e976e4ceced62711bba1a7d Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?= <k...@kix.es>
> > Date: Mon, 2 Apr 2012 23:20:30 +0200
> > Subject: [PATCH] WindowMaker: Class codes cleaned
> > 
> > The class codes are used in the icon, balloon and other parts. Some class 
> > codes are not used.
> > 
> > This patch identify the used codes, renumber them, delete the not used 
> > codes and document the codes.
> > ---
> >  src/WindowMaker.h |   20 ++++++++------------
> >  1 files changed, 8 insertions(+), 12 deletions(-)
> > 
> > diff --git a/src/WindowMaker.h b/src/WindowMaker.h
> > index e10b5ab..31a497b 100644
> > --- a/src/WindowMaker.h
> > +++ b/src/WindowMaker.h
> > @@ -26,22 +26,18 @@
> >  #include <limits.h>
> >  #include <WINGs/WINGs.h>
> >  
> > -
> >  /* class codes */
> >  typedef enum {
> > -    WCLASS_UNKNOWN = 0,
> > -    WCLASS_WINDOW = 1,             /* managed client windows */
> > -    WCLASS_MENU = 2,               /* root menus */
> > -    WCLASS_APPICON = 3,
> > -    WCLASS_DUMMYWINDOW = 4,        /* window that holds window group 
> > leader */
> > -    WCLASS_MINIWINDOW = 5,
> > -    WCLASS_DOCK_ICON = 6,
> > -    WCLASS_PAGER = 7,
> > -    WCLASS_TEXT_INPUT = 8,
> > -    WCLASS_FRAME = 9
> > +    WCLASS_WINDOW = 0,             /* Window contents */
> > +    WCLASS_MENU = 1,               /* Menus */
> > +    WCLASS_APPICON = 2,            /* Application Icon &
> > +                            * dockeable application outside
> > +                            * the clip/dock */
> > +    WCLASS_MINIWINDOW = 3, /* Application minimized */
> > +    WCLASS_DOCK_ICON = 4,  /* Dock, clip, dockeable app docked */
> > +    WCLASS_FRAME = 5               /* Window Frame (title, border,... */
> >  } WClassType;
> >  
> > -
> >  /*
> >   * generic window levels (a superset of the N*XTSTEP ones)
> >   * Applications should use levels between WMDesktopLevel and
> > -- 
> > 1.7.9.1
> > 
> > -- 
> > ||// //\\// Rodolfo "kix" Garcia
> > ||\\// //\\ http://www.kix.es/
> 
> > From b4d2de26ef2588c62e976e4ceced62711bba1a7d Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?"Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20(kix)"?= <k...@kix.es>
> > Date: Mon, 2 Apr 2012 23:20:30 +0200
> > Subject: [PATCH] WindowMaker: Class codes cleaned
> > 
> > The class codes are used in the icon, balloon and other parts. Some class 
> > codes are not used.
> > 
> > This patch identify the used codes, renumber them, delete the not used 
> > codes and document the codes.
> > ---
> >  src/WindowMaker.h |   20 ++++++++------------
> >  1 files changed, 8 insertions(+), 12 deletions(-)
> > 
> > diff --git a/src/WindowMaker.h b/src/WindowMaker.h
> > index e10b5ab..31a497b 100644
> > --- a/src/WindowMaker.h
> > +++ b/src/WindowMaker.h
> > @@ -26,22 +26,18 @@
> >  #include <limits.h>
> >  #include <WINGs/WINGs.h>
> >  
> > -
> >  /* class codes */
> >  typedef enum {
> > -    WCLASS_UNKNOWN = 0,
> > -    WCLASS_WINDOW = 1,             /* managed client windows */
> > -    WCLASS_MENU = 2,               /* root menus */
> > -    WCLASS_APPICON = 3,
> > -    WCLASS_DUMMYWINDOW = 4,        /* window that holds window group 
> > leader */
> > -    WCLASS_MINIWINDOW = 5,
> > -    WCLASS_DOCK_ICON = 6,
> > -    WCLASS_PAGER = 7,
> > -    WCLASS_TEXT_INPUT = 8,
> > -    WCLASS_FRAME = 9
> > +    WCLASS_WINDOW = 0,             /* Window contents */
> > +    WCLASS_MENU = 1,               /* Menus */
> > +    WCLASS_APPICON = 2,            /* Application Icon &
> > +                            * dockeable application outside
> > +                            * the clip/dock */
> > +    WCLASS_MINIWINDOW = 3, /* Application minimized */
> > +    WCLASS_DOCK_ICON = 4,  /* Dock, clip, dockeable app docked */
> > +    WCLASS_FRAME = 5               /* Window Frame (title, border,... */
> >  } WClassType;
> >  
> > -
> >  /*
> >   * generic window levels (a superset of the N*XTSTEP ones)
> >   * Applications should use levels between WMDesktopLevel and
> > -- 
> > 1.7.9.1
> > 
> 
> 
> -- 
> ||// //\\// Rodolfo "kix" Garcia
> ||\\// //\\ http://www.kix.es/
> 
> 
> --
> To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

-- 
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/


--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Reply via email to