El 31.05.2012 20:50, Christophe escribió:
Hi Carlos,
While we're at it, could I propose the attached patch instead? It
does the same thing and a few more I did not search for the first
time.
Regards,
Christophe.
Hi,
1st, I applied the patch (really, I copied and pasted) over
c82138eab959bc4f73b5c49de209188aab25b2a0 commit. The problem seems to be
gone. Thanks a lot!
2nd, I have some comments about the patch:
I think that
for (i = 0; i < (sizeof(panel->appChk)/sizeof(panel->appChk[0])); i++)
should be (see space+/+space)
for (i = 0; i < (sizeof(panel->appChk) / sizeof(panel->appChk[0]));
i++)
And one line has tabs+spaces. Please, change the spaces by one tab:
@@ -970,7 +970,7 @@ static void revertSettings(WMButton * button,
InspectorPanel * panel)
WMSetButtonSelected(panel->moreChk[i], flag);
}
if (panel->appFrm && wapp) {
- for (i = 0; i < 3; i++) {
+ for (i = 0; i < (sizeof(panel->appChk)/sizeof(panel->appChk[0]));
i++) {
int flag = 0;
The patch is very good, the part with ifdef is ugly in the original
source :-)
Carlos, Christophe, thanks for your quick help. I will continue with my
patches.
Cheers.
kix
----- Christophe <[email protected]> a écrit :
Hi Rodolfo,
Could you please have a try at the patch attached below? it may (or
may not) solve the problem.
Carlos,
Considering the nature of the patch, I'd suggest to include it
anyway if its fits your standards.
Regards,
Christophe.
----- Rodolfo kix Garcia <[email protected]> a écrit :
> El 31.05.2012 18:33, Carlos R. Mafra escribió:
> > On Thu, 31 May 2012 at 18:03:10 +0200, Rodolfo kix Garcia wrote:
> >> El 31.05.2012 17:54, Carlos R. Mafra escribió:
> >> >On Thu, 31 May 2012 at 17:20:30 +0200, Rodolfo kix Garcia
wrote:
> >> >>Hi,
> >> >>
> >> >>please, can anyone using the current next brach (updated) to
check
> >> >>if there is a bug?
> >> >>
> >> >>1. Launch any application
> >> >>2. Open the properties
> >> >>3. Click on "Reload"
> >> >>
> >> >>I didn't have this problem with the debian binary, but yes
with my
> >> >>developer binary at /usr/local/bin.
> >> >
> >> >I don't see any obvious problem with clicking the "Reload"
button
> >> >here.
> >> >What kind of problem do you see?
> >>
> >> Hi Carlos,
> >>
> >> thanks for your reply. wmaker restarts, this is the problem:
> >>
> >> Program received signal SIGSEGV, Segmentation fault.
> >
> > Ok, I definitely can't trigger it. Can you (git) bisect this?
>
> Hi Carlos,
>
> I think the problem is at commit
> c82138eab959bc4f73b5c49de209188aab25b2a0 (Haroldo Santos's patch,
in
> cc:).
>
(http://repo.or.cz/w/wmaker-crm.git/commitdiff/c82138eab959bc4f73b5c49de209188aab25b2a0)
>
> The previous commit (wmgenmenu: Add French and Spanish
translations)
> don't have the problem.
>
> I have not time now to make a patch. I will try to check it soon
(but
> not today), because I spent a lot of time trying to see if my new
> patches has bugs. If you (or Haroldo) can check it, perfect. I am
busy
> these days :-(
>
> Regards.
> kix
> --
> ||// //\\// Rodolfo "kix" Garcia
> ||\\// //\\ http://www.kix.es/
>
>
> --
> To unsubscribe, send mail to
[email protected].
--
||// //\\// Rodolfo "kix" Garcia
||\\// //\\ http://www.kix.es/
--
To unsubscribe, send mail to [email protected].
