On Tue, 21 Aug 2012 at 20:38:29 +0100, Carlos R. Mafra wrote: > On Tue, 21 Aug 2012 at 21:03:19 +0200, Rodolfo kix Garcia wrote: > > Hi, > > > > I am sending the wmbutton dockapp. This is the latest version that I > > found (0.6) (patch no 1), and then I apply some patches from Debian > > (thanks to Christian Aichinger (Greek0)), some of them with > > modifications. Other patches are new. > > > > I split the modifications to better understanding. The final version is > > not the Debian version, is the original version with patches. Debian > > version has different images and different configuration file. Debian > > files are not included. Probably, new icons should be included, because > > some of them are old (Netscape?). > > > > Patches: > > > > 1. Original version > > 2. Changed the patch for X11 (X11R6 is not longer used). Based on > > Christian patch. > > 3. .wmbutton renamed to sample.wmbutton. Based on Christian, but I use > > only this file for the user configuration and global configuration > > 4. Support for global configuration file. Christian patch. > > 5. Version simplification. Based on Christian, but the old variables are > > removed. > > 6. Better Makefile. Christian patch. > > 7. Code clean in wmbutton.c. I did a full code clean. > > 8. Added the manpage (Originally Debian manpage) > > 9. Bug with middle button > > 10. Code clean in wmbutton.h and wmb_libs.c > > 11. Removed initTooltip arguments (not used!) > > 12. Changed version to 0.7.0 > > Good, thanks a lot. > > But you should have written the "based on Christian" note on the commit > message, where it won't be lost in history. > > I'll ammend the logs of patches 2,3,4,5 and 6 to include the sentence: > > "Based on Christian Aichinger patch."
Ok, only patches 2 and 3 miss the sentence. I concluded too early that all the patches were missing it after seeing #2 and #3. Sorry. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.