On Sun, 9 Dec 2012, Rodolfo Garc?a Pe?as (kix) wrote:
diff --git a/src/icon.c b/src/icon.c index 13a0c94..ee441cd 100644 --- a/src/icon.c +++ b/src/icon.c @@ -63,7 +63,7 @@ static WIcon *icon_create_core(WScreen *scr, int coord_x, int coord_y); static void set_dockapp_in_icon(WIcon *icon); static void get_rimage_icon_from_icon_win(WIcon *icon); static void get_rimage_icon_from_user_icon(WIcon *icon); -static void get_rimage_icon_from_default_icon(WIcon *icon); +static RImage *get_default_icon_rimage(WScreen *scr); static void get_rimage_icon_from_x11(WIcon *icon);
Window Maker used to have an object oriented design. This means that functions in icon.c can be considered as methods of an icon object. This is why they normally take a reference to "self" as their first argument. With this change this function is probably no more a method of icon and may need to be moved somewhere else like you did with another function.
Other than that how do these patches address the issues we identified? Which behaviour does it improve? This was not clear to me from the log message.
Thanks, BALATON Zoltan -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
