On 03/04/2013 21:08, Carlos R. Mafra wrote: > On Wed, 3 Apr 2013 at 20:51:26 +0200, "Rodolfo García Peñas (kix)" wrote: >> On 03/04/2013 20:19, Carlos R. Mafra wrote: >>> On Wed, 3 Apr 2013 at 20:01:46 +0200, Rodolfo García Peñas (kix) wrote: >>>> From: "Rodolfo García Peñas (kix)" <[email protected]> >>>> >>>> Small code clean at startup.c >>>> --- >>>> src/startup.c | 16 ++++++---------- >>>> 1 file changed, 6 insertions(+), 10 deletions(-) >>>> >>>> diff --git a/src/startup.c b/src/startup.c >>>> index e0249ee..f9d4e52 100644 >>>> --- a/src/startup.c >>>> +++ b/src/startup.c >>>> @@ -415,16 +415,12 @@ WScreen *wScreenForRootWindow(Window window) >>>> if (wScreenCount == 1) >>>> return wScreen[0]; >>>> >>>> - /* >>>> - * Since the number of heads will probably be small (normally 2), >>>> + /* Since the number of heads will probably be small (normally 2), >>>> * it should be faster to use this than a hash table, because >>>> - * of the overhead. >>>> - */ >>>> - for (i = 0; i < wScreenCount; i++) { >>>> - if (wScreen[i]->root_win == window) { >>>> + * of the overhead. */ >>> >>> I don't care too much about the multiline comment style, but FYI you're >>> deviating from what's supposed to be wmaker's coding style. >>> >>> But as I said, I don't care too much. Applied. >>> >>> >> >> When I make changes in one file, I make changes about this things. Then >> I rebase it to make the patches "clean". And I create these clean patches. >> >> Feel free to drop these patches. I have a lot of changes here and >> sometimes I send some patches to stay near of the next branch. Else, is >> difficult to continue, for example if more people send their patches, >> and I need rewrite code. > > Your patches 1-4 are already upstream.
Ok. If you are unsure with 5, test 6 and swap them if you want. You can test 6 easily: - move the clip to the bottom of the screen. - make right click on it, on the bottom part. If you are in the last line of pixels, you won't see the menu. - Apply the patch, test again. > I just wanted to point out that the preferred multi-line comment is > as follows (quoting the kernel CodingStyle): > > The preferred style for long (multi-line) comments is: > > /* > * This is the preferred style for multi-line > * comments in the Linux kernel source code. > * Please use it consistently. > * > * Description: A column of asterisks on the left side, > * with beginning and ending almost-blank lines. > */ > > Ok, thanks. I will use it (but it waste 2 extra lines ... :-) ) -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to [email protected].
