Hi Rodolfo,
The idea is interesting, I'd propose to take the opportunity of the patch to
make a few changes below (or maybe that should be split in 2 patches):
----- Rodolfo García Peñas <k...@kix.es> a écrit :
> Hi,
>
> I am thinking in send this small patch for the info panel:
>
> diff --git a/src/dialog.c b/src/dialog.c
> index 6964495..63c11db 100644
> --- a/src/dialog.c
> +++ b/src/dialog.c
> @@ -1243,6 +1243,14 @@ void wShowInfoPanel(WScreen * scr)
> }
>
> strbuf = wstrappend(strbuf, _("\nAdditional support for: WMSPEC"));
you could take the opportunity to split this in 2:
- the string "Additional support" first, with the "_" for translation
- the "WMSPEC" afterward, without translation "_"
this might make translation strings a bit better
> +
> +#ifdef HAVE_XRANDR
> + if (has_randr)
> + strbuf = wstrappend(strbuf, " XRandR (In use)");
> + else
> + strbuf = wstrappend(strbuf, " XRandR (Not in use)");
similarly, I would suggest to separate the "XRandR" string which shall not be
translated.
On a pure personal point of view, I would suggest "Active/Inactive" instead,
but that's just a matter of taste...
> +#endif
> +
> #ifdef MWM_HINTS
> strbuf = wstrappend(strbuf, " and MWM");
Would suggest also to take the opportunity to remove the 'and' there for
translation job simplification. As a general matter, I would recommend to use a
comma for separating the keyword (something like ", XXX").
> #endif
>
> What do you think? The text is correct?
>
> Thanks,
> kix
> --
> ||// //\\// Rodolfo "kix" Garcia
> ||\\// //\\ http://www.kix.es/
>
>
> --
> To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
