Quoth Renan Traba,
simplified logic of handleMaximize function
I won't pretend that the logic wouldn't benefit from simplification.
But...
removed unneeded old_maximize flags
Despite the hairiness of the code the old_maximize flag does serve
a purpose. Windows end up where you intuitively expect them to
following multiple hotkey invocations.
Compare the following sequences of operations before and after the
patch, with two terminals on the screen.
1a. Maximize Horizontally
1b. Maximize Vertically
1c. Maximize
2a. Maximus
2b. Maximize Horizontally
2c. Maximus
2d. Maximus
3a. Maximize Horizontally
3b. Maximize Vertically
3c. Maximize Horizontally
3d. Maximize Vertically
4a. Maximize
4b. Maximize Horizontally
4c. Maximize Vertically
5a. Maximus
5b. Maximize Horizontally
5c. Maximize Vertically
5d. Maximize
5e. Maximus
etc etc.
The victim window should end up back to where it started in all
cases, because the old_maximize flag remembers the previously applied
operations and can be used to judge whether or not we should override
the old_geometry values.
With the patch as it stands the window gets into all sorts of
undefined states.
If old_maximize is restored I'm sure we could get the benefit of
the new corner functionality without losing the intuitive behaviour of
sequential maximise operations.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
