On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote:
> From: "Rodolfo García Peñas (kix)" <k...@kix.es>
> 
> When the screen is created, it creates the initial
> workspace. This workspace could not be created, because
> is not used. The workspaces are created later, so we can
> avoid to create this initial workspace here.
> 
> This is good because this initial workspace creates an extra
> clip, that is not needed too.
> 
> --------------------------8<----------------------------------
> --- a/src/screen.c
> +++ b/src/screen.c
> @@ -662,9 +662,6 @@ WScreen *wScreenInit(int screen_number)
> 
>         wNETWMInitStuff(scr);
> 
> -       /* create initial workspace */
> -       wWorkspaceNew(scr);
> -
>         /* create shared pixmaps */
>         createPixmaps(scr);
> --------------------------8<----------------------------------

I think you should not include the code in the commit message like
you started to do recently. It's overkill for simple things like this
and a bit annoying.

Just in _exceptional_ cases it helps, but I'd say that it didn't happen yet.

The same thing with including the result of 'grep', it's better
to avoid having them.


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.

Reply via email to