On Sun, 29 Sep 2013 at 13:01:48 +0200, Rodolfo García Peñas wrote: > On Sun, 29 Sep 2013, Carlos R. Mafra escribió: > > > On Sun, 29 Sep 2013 at 12:02:05 +0200, Rodolfo García Peñas (kix) wrote: > > > This patch includes the function "NumLockMask", that checks if the > > > Alt Modifier key is "NumLock". Then we can use this function in the > > > calls to Capture the key sequence and don't use this modifier. > > > > Have you seen the NUMLOCK_HACK in src/window.c? > > > > #ifdef NUMLOCK_HACK > > /* Also grab all modifier combinations possible that > > include, > > * LockMask, ScrollLockMask and NumLockMask, so that > > keygrabs > > * work even if the NumLock/ScrollLock key is on. > > */ > > wHackedGrabKey(key->keycode, key->modifier, > > wwin->frame->core->window, True, > > GrabModeAsync, GrabModeAsync); > > #endif > > > > Since the purpose seems to be the same I was wondering if something > > similar could be done with WPrefs too. > > Hi, > > I didn't see that code, some things: > > 1. My X11 knowledge is not too big, perhaps somebody can help with this code > and select between my patch and this code. > 2. IMO, the code (the patch I sent) in WPrefs should be always enabled > (without the preprocessor #ifdef) > 3. Perhaps the idea is the same, but I don't know how different methods > impact in the wmaker performance. > 4. Function wHackedGrabKey is defined and used in the src/ folder (wmaker) > and the patch I sent is defined and used in the WPrefs/ folder (WPrefs). > There are different applications. > > Finally, I was testing my patch with some modifiers (Fn, NumLock, CapsLock) > without problems. The modifier Scroll_Lock is detected as a key press, not as > key modifier.
I will apply your patch. WPrefs is independent from src/. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
