From: Christophe CURIS <christophe.cu...@free.fr> Hello,
This serie of patch fixes the code in WINGs toolkit that are related to 17 bugs reported by Coverity. 5 bugs should have been fixed from WUtil fixes (commit 515fb74c0c). It does not fix everything, there are 5 more bugs which will probably be ignored (Time of check versus Time of use), and 2 that will require a little bit of work to get things right (Resource leaks). #50042: Logically dead code #50046: Dereference after NULL check #50067: Dereference after NULL check #50102: Resource leak #50103: Resource leak #50104: Resource leak #50111: Resource leak #50118: Resource leak #50119: Resource leak #50133: Resource leak #50135: Resource leak #50136: Resource leak #50189: Dereference before NULL check #50192: Dereference before NULL check #50195: Dereference before NULL check #50197: Dereference before NULL check #50264: Write to pointer after free Fixed by commit 515fb74c0c: #50054: Dereference after NULL check #50055: Dereference after NULL check #50056: Dereference after NULL check #50057: Dereference after NULL check #50086: Improper use of negative value wcolorpanel.c: #50030: Unchecked return value from library -> to check #50227: Time of check versus Time of use #50228: Time of check versus Time of use #50230: Time of check versus Time of use wfilepanel.c: #50233: Time of check versus Time of use widgets.c: #50083: Missing break in switch -> to be investigated wtext.c: #50068: Dereference after NULL check -> to be investigated #50084: Missing break in switch -> to be investigated #50194: Dereference before NULL check -> to be investigated with #50068 wtextfield.c: #50261: Use after free -> false positive #50262: Use after free -> false positive #50263: Use after free -> false positive #50266: Use after free -> false positive wview.c: #50060: Dereference after NULL check -> to be investigated wwindow.c: #50069: Dereference after NULL check -> to be investigated #50202: Unintended sign extension -> to investigate Christophe. WINGs/dragdestination.c | 2 -- WINGs/wbrowser.c | 9 ++++++--- WINGs/wcolorpanel.c | 52 +++++++++++++++++++++++++++++++++++-------------- WINGs/wfilepanel.c | 6 ++++-- WINGs/wpopupbutton.c | 2 -- WINGs/wtext.c | 27 ++++++++++++++----------- WINGs/wtextfield.c | 13 ++++++------- WINGs/wwindow.c | 8 ++++---- 8 files changed, 73 insertions(+), 46 deletions(-) -- 1.9.2 -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
