[PATCH 14/15] WINGs: fix probable crash in drag'n'drop (Coverity #50264)

[Christophe]

From: Christophe CURIS <christophe.cu...@free.fr>

As reported by Coverity, the structure containing the callback functions
to handle the drag-and-drop actions could be freed but later re-used.
The correct behaviour is to keep the allocated memory for the structure.

Signed-off-by: Christophe CURIS <christophe.cu...@free.fr>
---
 WINGs/dragdestination.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/WINGs/dragdestination.c b/WINGs/dragdestination.c
index 2dba64a..2833b88 100644
--- a/WINGs/dragdestination.c
+++ b/WINGs/dragdestination.c
@@ -974,8 +974,6 @@ void WMSetViewDragDestinationProcs(WMView * view, 
WMDragDestinationProcs * procs
 {
        if (view->dragDestinationProcs == NULL) {
                view->dragDestinationProcs = 
wmalloc(sizeof(WMDragDestinationProcs));
-       } else {
-               free(view->dragDestinationProcs);
        }
 
        *view->dragDestinationProcs = *procs;
-- 
1.9.2


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.