On Mon, 19 May 2014 at 17:15:11 +0200, Amadeusz Sławiński wrote:
> Signed-off-by: Amadeusz Sławiński <am...@asmblr.net>
I'm sorry but I have to play the "boring" role here.
Please try to convince us about this patch by writing a commit
message with your motivation and some technical background as
well.
You are adding a config FrameFocusedBorderColor. Can you get/set
it using wm{get,set}style? What is its default value? I know it's
black because I read the code, but ideally you should state that
in the commit log.
Mentioning that you are adding the config to WPrefs is a must as
well. We want to know how to use this without reading the code.
> +static int setFrameFocusedBorderColor(WScreen * scr, WDefaultEntry * entry,
> void *tdata, void *foo)
^^^
I'm trying to get rid of this bad style: No space after * since you are
not multiplying WScreen by scr.
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
