[PATCH 09/11] WPrefs: fix memory leak when saving window handling settings (Coverity #50158)

[Christophe]

From: Christophe CURIS <christophe.cu...@free.fr>

As pointed by Coverity, the functions WMCreatePLString return a newly
allocated WMPropList, which must be released when not needed anymore.

Signed-off-by: Christophe CURIS <christophe.cu...@free.fr>
---
 WPrefs.app/WindowHandling.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/WPrefs.app/WindowHandling.c b/WPrefs.app/WindowHandling.c
index 9d7ab54..0976b17 100644
--- a/WPrefs.app/WindowHandling.c
+++ b/WPrefs.app/WindowHandling.c
@@ -222,7 +222,8 @@ static void showData(_Panel * panel)
 static void storeData(_Panel * panel)
 {
        WMPropList *arr;
-       char x[16], y[16];
+       WMPropList *x, *y;
+       char buf[16];
 
        SetBoolForKey(WMGetButtonSelected(panel->miconB), "NoWindowOverIcons");
        SetBoolForKey(WMGetButtonSelected(panel->mdockB), "NoWindowOverDock");
@@ -234,9 +235,13 @@ static void storeData(_Panel * panel)
        SetBoolForKey(WMGetButtonSelected(panel->tranB), 
"OpenTransientOnOwnerWorkspace");
 
        SetStringForKey(placements[WMGetPopUpButtonSelectedItem(panel->placP)], 
"WindowPlacement");
-       sprintf(x, "%i", WMGetSliderValue(panel->hsli));
-       sprintf(y, "%i", WMGetSliderValue(panel->vsli));
-       arr = WMCreatePLArray(WMCreatePLString(x), WMCreatePLString(y), NULL);
+       sprintf(buf, "%i", WMGetSliderValue(panel->hsli));
+       x = WMCreatePLString(buf);
+       sprintf(buf, "%i", WMGetSliderValue(panel->vsli));
+       y = WMCreatePLString(buf);
+       arr = WMCreatePLArray(x, y, NULL);
+       WMReleasePropList(x);
+       WMReleasePropList(y);
        SetObjectForKey(arr, "WindowPlaceOrigin");
 
        SetIntegerForKey(WMGetSliderValue(panel->resS), "EdgeResistance");
-- 
1.9.2


-- 
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.