On Fri, 22 Aug 2014 at 15:22:16 +0800, David Maciejak wrote: > This patch is merging some duplicate code related > to animation position (I also fixed most of the errors reported by > checkpatch).
Sorry, I should have said this in your earlier patch. Don't mix substantial coding style changes with new code, that's a recipe to make things hard to debug. Just suppose for a moment that someone finds that this patch causes a problem (e.g. using 'git bisect'). Now one needs to understand what in this patch causes the problem and the amount of unrelated changes make the task a pain. And if we revert the patch, all the coding style changes will be gone too but they had nothing to do with the problem. That's a clear indication that the patch is doing 'more than one thing' at a time, which is not good. Sorry, but I cannot accept the patch right now. I suggest to split it; one doing purely style changes and the other merging the code. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
