On Tue, Aug 26, 2014 at 9:22 PM, Carlos R. Mafra <[email protected]> wrote: > On Tue, 26 Aug 2014 at 9:17:54 +0800, David Maciejak wrote: >> This patch is saving about 80 lines of code by creating 2 new static >> fcts: create_rimage_from_xpm and is_xpm_error. > > This is a very good cleanup! > > But I'm a bit afraid of this patch since it's big and it > involves a core part (and the generated diff is a bit messy > to follow) > > Sorry for being to cautious again, but I think we would all profit in > the long run if you could split the patch: > > 1. Just add the functions in a standalone patch (the coding style cleanups > can be done here too) > > 2. Use the functions and remove the duplicated code. > > I think the flow will be clearer this way. > >
Patch split in 2 new patches enclosed.
0002-wrlib-remove-duplicate-code.patch
Description: Binary data
0001-wrlib-add-merged-code-in-2-distinct-functions.patch
Description: Binary data
