On Fri, Sep 26, 2014 at 9:37 PM, Carlos R. Mafra <crma...@gmail.com> wrote: >> >> On Fri, Sep 26, 2014 at 6:31 PM, Carlos R. Mafra <crma...@gmail.com> wrote: >> > On Fri, 26 Sep 2014 at 12:29:45 +0800, David Maciejak wrote: >> >> This patch is setting the default close keybinding >> >> in switch panel if any instead of the hardcoded esc key. >> > >> > What's the point of this? >> > >> > ESC is pretty standard, and I don't see much reason why one >> > would want to change it. Furthermore, I prefer the naming >> > 'escapeKey' instead of 'closeKey' because 'close' is associated >> > to ending applications, which is not the meaning here. > > On Fri, 26 Sep 2014 at 19:06:37 +0800, David Maciejak wrote: >> There is a default Close Active Window binding which can be set >> through WPrefs, that panel is just not following the wmaker standard >> and uses its own hardcoded keybinding. > > This explanation should have been written in the commit log... > > But still, I think the purpose of Close Active Window is different. > > It is the shortcut to close a window and there's no connection > with the ESC key in the switchpanel. The ESC key there is supposed > to 'cancel' operations in the switchpanel and this is logically > different from closing an application window. > > For example, if you have two windows A and B and start the switchpanel > to change the focus from window A to B, which now is raised above A. > While still keeping the switchpanel open you realize you don't want to > switch to window B. Pressing ESC in this situation gives you back the > focus on window A (like it was before). If you now 'close' the switchpanel > you will have the focus on window B instead. The meaning is different, > ESC is not about closing, it's about cancelling an operation.
Not sure how did you test it and understood the patch. The behaviour is the same, only the current key is set according to user preference. Close is used to close a window or panel for that case, in this case cancelling the current switch operation. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
