Great, i will send an 'official' patch later. yeah the "Workspace border" is OFF in my env, I believe there is an issue somewhere as for some apps the extra spacing is located at the bottom like in the screenshot i enclosed...
thanks, david On Thu, Oct 9, 2014 at 1:22 PM, Miikka Veijonen <miikka.veijo...@gmail.com> wrote: > Hi, > > Now it works as expected! I applied both your patches and compiled the most > recent version from git: > http://repo.or.cz/w/wmaker-crm.git?a=commit;h=f01852f079c402b54180d1d08e96d95d4b3f5049 > > Thank you very much! > > BTW: You mentioned that you've some extra space between maximized window and > the dock. There is one option (WPrefs: under fifth icon) that says "Workspace > border". If I set this to something else than OFF then there then will be > that space between dock and maximized windows. > > > Kind Regards, > Miikka > > ----- Original Message ----- > From: "David Maciejak" <david.macie...@gmail.com> > To: "Miikka Veijonen" <miikka.veijo...@gmail.com> > Cc: "Window Maker Devel" <wmaker-dev@lists.windowmaker.org> > Sent: Wednesday, 8 October, 2014 5:44:05 PM > Subject: Re: WMaker 0.95.6: "Maximize window" bug when using multiple screens > > hum, seems some code was moved to xinerama.c. > See commit > http://repo.or.cz/w/wmaker-crm.git/commit/0faff93cf770927b6f5c3811688cd5e42d498970 > > Could you test the new patch enclosed ? > > thx, > david > > On Wed, Oct 8, 2014 at 1:23 PM, Miikka Veijonen > <miikka.veijo...@gmail.com> wrote: >> Hi, >> >> I tried this patch but the problem is still there. >> >> -Miikka >> >> ----- Original Message ----- >> From: "David Maciejak" <david.macie...@gmail.com> >> To: "Miikka Veijonen" <miikka.veijo...@gmail.com> >> Cc: "Window Maker Devel" <wmaker-dev@lists.windowmaker.org> >> Sent: Wednesday, 8 October, 2014 2:27:55 AM >> Subject: Re: WMaker 0.95.6: "Maximize window" bug when using multiple screens >> >> I don't think the issue i mentioned is caused by the Gnome Terminal as >> i have the same issue with other Gnome app and not Gnome app but for >> example firefox is maximizing well. >> For your case, can you just test the patch enclosed ? >> >> --- a/src/actions.c >> +++ b/src/actions.c >> @@ -1739,6 +1739,7 @@ void wArrangeIcons(WScreen *scr, Bool arrangeAll) >> } *vars; >> >> int isize = wPreferences.icon_size; >> + int dock_head = scr->xine_info.primary_head; >> >> vars = (struct HeadVars *)wmalloc(sizeof(struct HeadVars) * heads); >> >> @@ -1746,7 +1747,7 @@ void wArrangeIcons(WScreen *scr, Bool arrangeAll) >> WArea area = wGetUsableAreaForHead(scr, head, NULL, False); >> WMRect rect; >> >> - if (scr->dock) { >> + if (scr->dock && dock_head == head) { >> int offset = wPreferences.icon_size + DOCK_EXTRA_SPACE; >> >> if (scr->dock->on_right_side) >> >> On Wed, Oct 8, 2014 at 6:20 AM, David Maciejak <david.macie...@gmail.com> >> wrote: >>> Yep sorry I was not clear, for me there are 2 issues reported in your >>> screenshot :) >>> >>> >>> On Tuesday, October 7, 2014, Miikka Veijonen <miikka.veijo...@gmail.com> >>> wrote: >>>> >>>> Hi, >>>> >>>> That wasn't the issue I meant. I think the behavior you described is >>>> caused by Gnome terminal: I think it resizes itself to match with font >>>> width. All other applications maximize them selves right next to the dock. >>>> >>>> The original bug I meant (example with Gedit): >>>> >>>> http://koti.kapsi.fi/wapsi/wmaker-bug2.png >>>> >>>> The bug isn't present in 0.95.5 version of WMaker: >>>> http://koti.kapsi.fi/wapsi/wmaker-no-bug-0.95.5.png >>>> >>>> >>>> -Miikka >>>> >>>> ----- Original Message ----- >>>> From: "David Maciejak" <david.macie...@gmail.com> >>>> To: "Window Maker Devel" <wmaker-dev@lists.windowmaker.org> >>>> Cc: "Miikka Veijonen" <miikka.veijo...@gmail.com> >>>> Sent: Tuesday, 7 October, 2014 5:47:35 PM >>>> Subject: Re: WMaker 0.95.6: "Maximize window" bug when using multiple >>>> screens >>>> >>>> BTW, as Miikka is reporting, i can see that there is a space between >>>> the terminal on the right and the dock, that the same thing i am also >>>> experiencing. >>>> >>>> In that case, when fully maximised i believe the window should be >>>> sticked to the dock or is that space intended ? >>>> >>>> thx, >>>> david >>>> >>>> On Tue, Oct 7, 2014 at 9:24 PM, Miikka Veijonen >>>> <miikka.veijo...@gmail.com> wrote: >>>> > Hi, >>>> > >>>> > I upgraded my Window Maker to 0.95.6 and found a bug that wasn't present >>>> > in version 0.95.5: >>>> > >>>> > 0. Before reporting this bug I already: >>>> > [X] read the NEWS, README and INSTALL files >>>> > [X] read the list of already known bugs in the BUGS file >>>> > [X] downloaded and tried the latest version of WindowMaker >>>> > >>>> > 1. What happened: >>>> > [ ] could not compile >>>> > [ ] crashed >>>> > [ ] configuration option does not work >>>> > [X] weird behavior >>>> > [ ] cosmetic >>>> > [ ] some problem with WPrefs >>>> > [ ] others: ................................... >>>> > >>>> > 2. Detailed description of what happened: >>>> > >>>> > Using multiple screens / monitors WMaker reserves space for dock on >>>> > screen which doesn't have dock when maximizing window. Dock position is >>>> > set >>>> > to "Keep on top". Here is a link to screenshot where you can see the >>>> > problem: http://koti.kapsi.fi/wapsi/wmaker-bug.png >>>> > >>>> > 3. How to reproduce the bug, if known: >>>> > >>>> > Everytime I maximize a window on screen which doesn't have dock. >>>> > >>>> > 4. Configure time options you specified: >>>> > [ ] --enable-kanji >>>> > [ ] --disable-shape >>>> > [ ] --enable-single-icon >>>> > [ ] --enable-modelock >>>> > [ ] Others: --prefix=/usr --libdir=/usr/lib64 >>>> > >>>> > >>>> > 5. Changes to the src/wconfig.h file: >>>> > - >>>> > >>>> > 6. The error occurred during: >>>> > [ ] configuration >>>> > [ ] compilation >>>> > [ ] start-up >>>> > [X] use >>>> > >>>> > 7. Changes made to the configuration files, if the error occurred during >>>> > use: >>>> > - >>>> > >>>> > 8. Error messages output: >>>> > - >>>> > >>>> > 9. Fix, if known: >>>> > Check if the screen has a dock => >>>> > -If it does: reserve space for it when maximizing (if dock position is >>>> > set to "Keep on top"- >>>> > -If it doesn't: maximize the window normally (using all available space) >>>> > >>>> > 10. Other Notes: >>>> > This bug isn't present in 0.95.5. >>>> > >>>> > Operating System (run "uname -a"): 3.10.0-123.8.1.el7.x86_64 >>>> > Distribution (if applicable): CentOS Version: 7.0 >>>> > WindowMaker Version (run "wmaker -version"): 0.95.6 >>>> > >>>> > >>>> > Kind Regards, >>>> > Miikka >>>> > >>>> > >>>> > -- >>>> > To unsubscribe, send mail to >>>> > wmaker-dev-unsubscr...@lists.windowmaker.org.
