> On Thu, Oct 9, 2014 at 6:35 PM, Carlos R. Mafra <crma...@gmail.com> wrote: > >> On Thu, Oct 9, 2014 at 5:19 PM, Carlos R. Mafra <crma...@gmail.com> wrote: > >> > Thanks. > >> > > >> > Do you have an idea why this bug is not present in 0.95.5? > >> > > > > > On Thu, 9 Oct 2014 at 18:02:27 +0800, David Maciejak wrote: > >> Cause there was a change in wGetUsableAreaForHead function between > >> 0.95.5 and 0.95.6 at > >> > >> http://repo.or.cz/w/wmaker-crm.git/blobdiff/895a6e97e1d0cbafd9fd6a5b1aba674275d4eed4..0faff93cf770927b6f5c3811688cd5e42d498970:/src/xinerama.c > >> > >> which is tweaking the usable area size. > >> > > > > But that part of the code was moved from screen.c in this commit > > (which Miika found was the culprit): > > > > commit 952319ae60d0a3280233bfddeb277ded6f850702 > > Author: Amadeusz SBawiDski <am...@asmblr.net> > > Date: Wed Nov 13 15:39:11 2013 +0100 > > > > move maximization size adjustments to maximization function > > > > now wGetUsableAreaForHead returns better result > > > > > > > > while also removing the 'dock_head == i' check inside the if(). > > > > I was wondering if reinstating the dock_head check could fix > > this too. But I'd like to know what was the motivation for > > Amadeusz patch, since for him it was returning a "better result". > > > > I should have complained about the commit log :-)
On Thu, 9 Oct 2014 at 19:57:02 +0800, David Maciejak wrote: > yep i don't know the details either, what i can say is that i tested > yesterday to backport the test and the code in xinerama.c > > dock_head = scr->xine_info.primary_head > > but it was not working in my test env. Ok, thank you very much for your effort on this. I'm going to apply the patch, but I just thought that maybe computing the intersection area to make the decision about the dock being present might not be the most elegant solution. The code in 0.95.5 seems to be simpler at first inspection. But in any case, thank you for fixing this. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
