From: Christophe CURIS <christophe.cu...@free.fr>
As pointed by Coverity, the sizeof used was not done on the right type.
This worked because the element was a pointer all pointers types have the
same size in most platforms.
For code maintainability, the code will now take the size from the first
element of the array to be sorted, so that if the structure gets changed
someday the expression will stay valid.
Signed-off-by: Christophe CURIS <christophe.cu...@free.fr>
---
src/moveres.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/moveres.c b/src/moveres.c
index e00b3ed..8640511 100644
--- a/src/moveres.c
+++ b/src/moveres.c
@@ -776,10 +776,10 @@ static void updateMoveData(WWindow * wwin, MoveData *
data)
/* order from closest to the border of the screen to farthest */
- qsort(data->topList, data->count, sizeof(WWindow **), compareWTop);
- qsort(data->leftList, data->count, sizeof(WWindow **), compareWLeft);
- qsort(data->rightList, data->count, sizeof(WWindow **), compareWRight);
- qsort(data->bottomList, data->count, sizeof(WWindow **),
compareWBottom);
+ qsort(data->topList, data->count, sizeof(data->topList[0]),
compareWTop);
+ qsort(data->leftList, data->count, sizeof(data->leftList[0]),
compareWLeft);
+ qsort(data->rightList, data->count, sizeof(data->rightList[0]),
compareWRight);
+ qsort(data->bottomList, data->count, sizeof(data->bottomList[0]),
compareWBottom);
/* figure the position of the window relative to the others */
--
2.1.1
--
To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
