On 7/5/06, Oshani Seneviratne <[EMAIL PROTECTED]> wrote:
> Are you planning on creating some unit tests.
I have already written some unit tests, and I'm more than happy to
contribute it.
great - please open a JIRA and attach a patch.
> It would be great if we could run all the existing unit tests through the
OM/AXIOM
> code - ie run them once for DOM and once for OM/AXIOM.
Did you mean writing separate test cases for OM, or are you thinking
of some other abstraction?
I'm thinking AllWodenTests gets renamed to AllWodenTestsDOM. Then we
copy AllWodenTestsDOM to AllWodenTestsOM which will set the
org.apache.woden.WSDLFactory property to be
org.apache.woden.internal.OMWSDLFactory then run the tests. Then
create a AllWodenTests class which runs both AllWodenTestsDOM and
AllWodenTestsOM.
While developing a new feature I would probably only run
AllWodenTestsDOM then when all the tests pass for that run
AllWodenTests to make sure OM works too.
If it's the former, it is almost done :).
Great
In most of the cases it was
just a matter of rewriting those existing test cases to pass the
factory impl name to obtain the OMWSDLFactory.
Hmm, sounds like you've done what I was suggesting above but in a different way.
I can send in those
test cases after integrating them into the Woden test suite. However,
if there's a better way, please advice.
Also, about the concern regarding the users of DOMWSDLReader having to
have Axiom and Stax jars, etc... : Well, how about separating the two
implementations, so that the users will only need the jars that are
required for their preferred parser?
I'd prefer to keep the number of jars / distributions to a minimum to
keep things simple for our users. There shouldn't be a problem if the
user is using default DOM and axiom / stax jars aren't there.
This might involve the OM stuff to be moved into a different package.
Some package restructuring might be a good idea anyway. We've got DOM
and OM classes in org.apache.woden.internal then separated some DOM
classes out into org.apache.woden.internal.util.dom and some OM
classes into org.apache.woden.internal.util.om. There seems to be
some common code across these two packages so any rationalisation you
can think of would be good.
But, if total separation is needed I guess there would be some code
duplicated!
Any thoughts on this?
Thanks and regards,
Oshani.
Thanks,
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
