Hi John, Your proposal looks really good, and it would be a good way to support the 2 parsing models. Just to let you know, I have also been thinking of a solution for this. But I guess I have thought of it in an entirely different way!
What I've come to realize was that those XMLAttr implemented classes use the ownerEl (currently a DOM element) mainly to get the QName of the attribute value. But in some of the classes, it just returns the attribute value itself without any reference to the ownerEl. In the case of the ExtensionDeserializer, the ownerEl is used to get attribute value specific info through DOMUtils. So, I was thinking of a way in the lines of changing the method signatures of those XMLAttr classes and ExtensionDeserializer that use DOM elements. These signatures could be somewhat generic ones, where it would be possible to directly send the required info without the need to send the whole element. I really do not know whether there are any other requirements in those classes that needs to be satisfied from the ownerEl. If so, this approach won't be that good and also there could be other code changes that I have not foreseen. So, lets go with your proposal which is cleaner and is much more elegant :). However, I have one particular concern. How would it be possible to obtain the attribute specific info (which I believe to be a parser specific thing in the current approach) from an ElementSource? For eg: in all of the unmarshall method implementations of the ExtensionDeserializer, DOMUtils is used to obtain the attribute info. So, there is a need to have a check to see what kind of an instance we are getting for the ElementSource and use DOMUtils or OMUtils accordingly there, isn't it?. I suppose this is not a problem, but I am wondering whether there is a way to abstract this. I apologise if I'm missing something very obvious! Thanks and Regards, Oshani --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
