Hi John, Please see my comments in line.
On 9/8/06, John Kaputin <[EMAIL PROTECTED]> wrote:
Oshani, in the WODEN-44 branch... I have added some error messages to the Messages.properties file and updated the error numbers used in the code.
Thanks for reviewing the code and making the necessary changes!
I have made some other changes to some of the DOM impl classes, but not yet to the OM impl classes.
Are you planning to do the same changes to the OM impl classes? (I mean correcting the error code and the checks for null arguments). Is there anything else that needs to be changed in your opinion?
I now think that ElementSource.setSource implementations should throw an IllegalArgumentException rather than a WSDLException if the source argument is of the wrong type. 'throws WSDLException' can then be removed from the DOMElementSource.setSource method declaration. Then in the reader.createElementSource method implementation, the try/catch block can be removed. What do you think?
+1. Let's make that change. However I do not understand what you mean by "Then in the reader.createElementSource method implementation, the try/catch block can be removed." The error still has to be recorded there some how, isn't it? I believe I forgot to discuss about the introduction of the createElementSource method in the WSDLReader interface. The rationale behind introducing it there was to enable any element in the WSDL to wrap itself in an ElementSource (obviously :) ) through any of the reader implementations. I hope it's okay to have such an element level method in the WSDLReader interface. If not, let's discuss. Thanks, Oshani. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
