[ 
https://issues.apache.org/jira/browse/WODEN-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12486070
 ] 

John Kaputin commented on WODEN-156:
------------------------------------

Is this JIRA based on a requirement you have for user-defined extensions to the 
Interface component? That is, for Interface extensions not defined by the WSDL2 
spec. If so, I can add the buildInterfaceExtensions method as requested. 
However, to make use of this you will still need to subtype and implement the 
ComponentExtensions interface and register this via the ExtensionRegistry API. 
Bear in mind also, that the extensions programming model (API) will likely 
change when I rework the Woden extensions model for JIRAs WODEN-47 and WODEN-56 
in our M8 release.  Assuming you have tested your patch, can you please attach 
test cases to support the code. I can rework them into the Woden junit format.

Woden's support for extensions has so far been limited to the extensions 
defined by the WSDL 2.0 spec, which includes some extensions on 
InterfaceOperation - hence the presence of the 
buildInterfaceOperationExtensions method in ComponentModelBuilder. There's no 
support yet for user-defined extensions on the other Interface components 
(Interface, InterfaceFault, InterfaceFaultReference, 
InterfaceMessageReference).  Our intention is to support user-defined 
extensions on all WSDL components, but we just haven't done those others yet. 
WODEN-47 and WODEN-56  will fix this.  

As part of that work, I'd like to eliminate the ComponentModelBuilder class. 
Most of its component model building behaviour has already been factored out 
into the WSDL model. ComponentModelBuilder is still used simply to set up 
access to the component extension properties in the component model.

There were a couple of minor problems with woden-component1.patch which I can 
correct. The buildInterfaceExtensions method does not get called, but I can see 
from the original patch file where it is meant to be called. The second problem 
is that when this method calls createComponentExtensions it specifies the 
InterfaceOperation.class. It should specify Interface.class.

> Parser does not properly handle component extensions for interfaces
> -------------------------------------------------------------------
>
>                 Key: WODEN-156
>                 URL: https://issues.apache.org/jira/browse/WODEN-156
>             Project: Woden
>          Issue Type: Bug
>          Components: Parser
>         Environment: All
>            Reporter: Ajith Harshana Ranabahu
>         Attachments: woden-component.patch, woden-component1.patch
>
>
> The parser does not query the extension registry or add the relevant 
> component extensions to the interface object

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to