[
https://issues.apache.org/jira/browse/WODEN-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Kaputin updated WODEN-176:
-------------------------------
Attachment: setParentElement_test_changes.patch
setParentElement_src_changes.patch
Uploading src and test patch files.
> Remove the setParentElement method from the API
> -----------------------------------------------
>
> Key: WODEN-176
> URL: https://issues.apache.org/jira/browse/WODEN-176
> Project: Woden
> Issue Type: Bug
> Reporter: John Kaputin
> Assignee: John Kaputin
> Fix For: M8
>
> Attachments: setParentElement_src_changes.patch,
> setParentElement_test_changes.patch
>
>
> Since WODEN-40, the Element API uses composition rather than aggregation.
> Elements have addXXXX methods that instantiate their child elements and set
> the parent element. It should no longer be necessary nor possible to set the
> parent element explicitly via the Woden API.
> The setParentElement method should be removed from the NestedElement
> interface (so it just retains a getParentElement method) and the
> setParentElement methods implemented in package
> org.apache.woden.internal.wsdl20 should be given default access (package
> private) so that they are only available to the addXXXX methods within the
> WSDL impl classes.
> The calls to setParentElement in the parseXXXX methods of BaseWSDLReader are
> redundant and should be removed. Some testcases also have redundant calls to
> setParentElement and those should be removed too. Providing the correct API
> programming model is used to instantiate objects (via the addXXXX methods),
> the parent element will always be initialised correctly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
