Remove WSDLReader.readWSDL methods that take an ErrorHandler parameter
----------------------------------------------------------------------
Key: WODEN-179
URL: https://issues.apache.org/jira/browse/WODEN-179
Project: Woden
Issue Type: Improvement
Reporter: John Kaputin
Fix For: M8
Each type of readWSDL method (i.e. URI argument, WSDLSource arg) also offers a
signature that takes an ErrorHandler object. ErrorHandler is just one type of
user configuration that may be done via the WSDLReader. Others include setting
the ExtensionRegistry and URIResolver. It seems inconsistent to offer
ErrorHandler configuration via the readWSDL methods, while explicit setters are
used for the others. I think I did this originally as a convenience method, but
I prefer a programming model that preserves the encapsulation of ErrorReporter
and maintains a consistent approach across the WSDLReader API.
This means the client would code:
reader.getErrorReporter().setErrorHandler(myErrHandler);
reader.readWSDL(wsdlUri);
rather than:
reader.readWSDL(wsdlUri, myErrHandler);
A slightly longer pgm model, but better encapsulation and with the improved
scoping of share objects brought about by WODEN-177, it becomes more obvious
that this configuration change is a persistent change to the ErrorReporter,
hence scoped across Woden, not just a temporary change for the life if the
readWSDL invocation.
The readWSDL methods in question are not used by Axis2, so I'd prefer to remove
them rather than deprecate across releases, but we should post to the woden-dev
list to see if there are any objections.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
