John/Dan, Sorry for the delay in reviewing the code. I don't have a lot of spare time.
I made at start at this and immediately noticed a couple of javadoc problems when I ran the buildAll Ant target: [javadoc] E:\workspaces\WSD2\woden\src\org\apache\woden\wsdl20\fragids\BindingPart.java:75: warning - @return tag has no arguments. [javadoc] Building index for all classes... [javadoc] E:\workspaces\WSD2\woden\src\org\apache\woden\wsdl20\fragids\EndpointPart.java:41: warning - Parameter "service" is documented more than once. I'll update the Jira and report further comments there. Arthur Ryman, PhD, AoT, DE Process and Portfolio Management, Rational Division phone: +1-905-413-3077, TL 969-3077 assistant: +1-905-413-3831 (T/L: 318-8867) fax: +1-905-413-4920, TL 969-4920 mobile: +1-416-939-5063, text: [EMAIL PROTECTED] ----- Forwarded by Arthur Ryman/Toronto/IBM on 08/21/2007 09:31 AM ----- Arthur Ryman/Toronto/IBM 08/14/2007 03:52 PM To [email protected] cc [email protected] Subject Re: Review toString() with fragids (WODEN-32) John, Yes, I'll review. I'm glad Dan has made such great progress. Arthur Ryman, PhD, AoT, DE Process and Portfolio Management, Rational Division phone: +1-905-413-3077, TL 969-3077 assistant: +1-905-413-3831 (T/L: 318-8867) fax: +1-905-413-4920, TL 969-4920 mobile: +1-416-939-5063, text: [EMAIL PROTECTED] John Kaputin <[EMAIL PROTECTED]> 08/12/2007 06:32 PM Please respond to [email protected] To [email protected] cc Subject Review toString() with fragids (WODEN-32) Arthur, I have committed Dan's patches for WODEN-32, implementing the WSDL component toString() methods with fragids. Would you like to review the code? It includes a new testcase that shows the expected fragids. regards, John Kaputin Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
