[
https://issues.apache.org/jira/browse/WODEN-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12522523
]
John Kaputin commented on WODEN-65:
-----------------------------------
r569372
Initial commit of the patch files to the 'woden65' branch in SVN.
This looks pretty good. Thanks Sagara. There were several unnecessary
whitespace changes in DOMUtils, probably resulting from WODEN-166 (eol style),
so I removed these before committing the code.
Further action required:
1) In the supplied testcase, the wsdl:service element in the serialized
document does not have a closing tag
2) All of the files must have the text in apache-boilerplate.txt added to the
beginning of the file.
3) A bit more class and method Javadoc is needed, at least for any API
interfaces and methods.
4) Testcases should be include, in Junit form as part of the Woden test suite
in the /tests folder. A testcase that serializes some WSDL and checks that it
contains all the expected content would be ideal . This could be achieved in
various ways, from checking strings to deserializing again and checking the
content of the DOM model.
5) Indentation of the serialized WSDL could be improved. The inline schema in
the <types> element was all left-aligned (no indentation).
> Woden elements must have serialize methods
> ------------------------------------------
>
> Key: WODEN-65
> URL: https://issues.apache.org/jira/browse/WODEN-65
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: Eran Chinthaka
> Assignee: Sagara Gunathunga
> Attachments: BaseWSDLWriter.java.txt, DOMUtils.java.txt,
> DOMWSDLFactory.java.txt, DOMWSDLWriter.java.txt, OMWSDLFactory.java.txt,
> OMWSDLWriter.java.txt, sample1.java, test.wsdl, WriterFeatures.java.txt,
> WSDLFactory.java.txt, WSDLWriter.java.txt
>
>
> When we load a WSDL in to Woden object model, there is no way to serialize
> the object model in to an output stream. This is very much useful when some
> one wants to make sure Woden can properly spit out what it has read.
> And there is a requirement from Axis2 also to make Woden element serializable
> to cater for ?wsdl2 requests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
