[
https://issues.apache.org/jira/browse/WODEN-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524195
]
John Kaputin commented on WODEN-178:
------------------------------------
r571605
Committed Dan's patch with a few changes to the testcases - mainly to fix
resulting NPEs by coding the tests to use the proper Woden API programming
model and to complete some missing tests for testGetXmlSchemaElement,
testGetMessageContentModel and testGetElementDeclarations.
> DescriptionImpl methods addElementDeclaration and addTypeDefinition should
> not be public
> ----------------------------------------------------------------------------------------
>
> Key: WODEN-178
> URL: https://issues.apache.org/jira/browse/WODEN-178
> Project: Woden
> Issue Type: Improvement
> Reporter: John Kaputin
> Assignee: Dan Harvey
> Fix For: M8
>
> Attachments: Woden-178.patch.txt
>
>
> These two methods are defined as public methods on DescriptionImpl but as we
> don't yet have an updatable Component API, they are not defined on the
> Description component interface. The component model is currently derived
> from the element model and these methods are only used by
> ComponentModelBuilder. As this is now in the same package as DescriptionImpl,
> these two methods should be made package private. We can make them public
> later if they are added to the Woden API.
> That's the easy part. There are also several testcases that call these
> methods as they 'hack together'' a WSDL model for their tests. These will
> need to be changed so that the ElementDeclarations and TypeDefinitions are
> derived from the Element model, rather than instantiated directly then
> explicitly added to the model by the test client. To do this, the test code
> will need to parse a <xs:schema> element as a XmlSchema object and access it
> via the normal Woden API.
> For an example, see the code in
> WSDLDocumentValidatorTest.testTestAssertionSchema1066(). It parse a string
> representation of an xs:schema and adds this to a TypesElement that has been
> created via the Woden programming model. The getElementDeclarations and
> getTypesDefinitions can then be called on DescriptionElement.toComponent().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
