[
https://issues.apache.org/jira/browse/WODEN-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561366#action_12561366
]
John Kaputin commented on WODEN-56:
-----------------------------------
Jeremy,
what does this issue relate to specifically? Is it the use of the Attr impl
classes in org.apache.woden.internal.xml when registering extension attributes
in the ExtensionRegistry? These were created to as part of the woden
implementation, for use by Woden's implementation of its SOAP and HTTP
extension APIs. Is the issue that users will benefit from reusing these classes
too, in which case they should be API public? If so, it's worth noting that
they are not exhaustive - they just cover the attribute types defined in the
Part 2 adjuncts spec. User may require other types of attributes, but I guess
they can define those as part of their own extensions.
Or was it to do with the SOAP and HTTP ExtensionsImpl classes extending
ComponentExtensionsImpl? Again, ComponentExtensionsImpl was created to refactor
reusable code for use within the Woden implementation (e.g. in the
implementation of the SOAP and HTTP extensions). However, we could perhaps make
this an API public abstract super class, instead of an Interface, so that
user-defined extensions can inherit from it. Is this what you had in mind?
> Extensions' impl classes shouldn't have to use *internal* classes in their
> implementation
> -----------------------------------------------------------------------------------------
>
> Key: WODEN-56
> URL: https://issues.apache.org/jira/browse/WODEN-56
> Project: Woden
> Issue Type: Improvement
> Components: Parser
> Reporter: Jeremy Hughes
> Assignee: John Kaputin
> Fix For: M8
>
>
> An extension writer shouldn't be expected to use any classes internal to
> Woden (ie ones that have 'internal' in their package name). Everthing an
> extension implementation (as well as interface) needs to get to should be on
> an external package.
> We should eat our own food by changing the SOAP and HTTP extensions to do
> this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
