Hi All,

+1 for re-factoring the project structure. In addition to MVN build system,
there exist an ANT build file, which IMHO would be redundant.

On the other hand when we say mvn idea:idea ; it will create a structure
which is not suitable for development. This is mainly due to the fact that
woden-api, impl-dom, impl-om just contain the pom.xmls and the artifact
creation is handle through  a very complex filtering mechanism in
maven-jar-plugin.

IMHO,  if the classes and resource could be copied to respective directories
(woden-api, woden-impl-dom and wonden-impl-om), it will be really easily to
maintain clean pom.xml. Since Woden artifacts are OSGi bundles, it is quite
easy to configure the maven-bundle-plugin to create the proper package
imports & exports.

Thank you!

Saminda

On Tue, Jun 24, 2008 at 5:58 PM, Sagara Gunathunga <
[EMAIL PROTECTED]> wrote:

> Hi guys ,
> I also had a doubt about the Woden project layout , it is very easy to
> work with both Maven and Eclipse when we follow the Maven -like
> project layout. Axis2 project layout is such a good example. I think
> we also can use similar layout.
>
> Sagara Gunathunga
>
> Blog - ssagara.blogspot.com
> Web - http://sagaras.awardspace.com
>
> On Tue, Jun 24, 2008 at 3:22 AM, Jeff MAURY <[EMAIL PROTECTED]>
> wrote:
> >
> > Who is in charge of this refactoring ?
> > Do you want me to do it ?
> > As I don't have a commint access, do you want me to refactor locally on
> my machine and then submit the diff file to the Woden dev community ?
> >
> > Regards
> > Jeff MAURY
> >
> >
> > On 6/23/08, Lawrence Mandel <[EMAIL PROTECTED]> wrote:
> >>
> >> Looks good Jeff.
> >>
> >> I think you can remove the eclipseplugin folder. AFAIK this hasn't been
> >> used in some time.
> >>
> >> The WSDL viewer is a Woden tool for generating a human readable (nicely
> >> formatted) document from the WSDL doc. This should probably live in
> tools
> >> for now but I'm also fine with creating a separate module if you'd like
> to
> >> keep the converter separate.
> >>
> >> Lawrence
> >>
> >>
> >>
> >>
> >>
> >> "Jeff MAURY" <[EMAIL PROTECTED]>
> >> Sent by: [EMAIL PROTECTED]
> >> 06/23/2008 11:22 AM
> >> Please respond to
> >> [email protected]
> >>
> >>
> >> To
> >> [email protected]
> >> cc
> >>
> >> Subject
> >> Re: Question about layout
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> On Mon, Jun 23, 2008 at 4:17 PM, John Kaputin (gmail) <
> [EMAIL PROTECTED]
> >> > wrote:
> >> >
> >> > Hi Jeff,
> >> > last year when the ANT and Maven build was changed to separate the API
> >> and the DOM and OM implementations, there was some talk about building
> the
> >> WSDL 2.0 tools into a separate tools module. At that time the only tool
> >> was the converter, but the WSDL 2 printer has since been added. This
> could
> >> be a good thing. Currently the converter is built into the DOM
> >> implementation jar. It should probably be in a separate jar.
> >> >
> >> > Are you proposing to refactor the src/ directory into some other
> >> maven-like module structure that matches the  modules created by the
> >> build?  Can you  post a quick proposal.
> >>
> >> John,
> >>
> >> you are right. The layout I propose is a layout inspired by Maven
> >> conventions. Please find a short description of what  I propose:
> >>
> >> woden/java/pom.xml: main woden pom declaring modules woden-api,
> woden-om,
> >> woden-dom and woden-tool
> >> woden/java/woden-api: directory for the Woden API under which we find
> >> src/main/java: sources for packages org.apache.woden,
> >> org.apache.woden.internal except tool, om, dom, ant
> >> resources/main/java: resources (schemas, ...)
> >> woden/java/woden-om: directory for the Woden OM Impl under which we find
> >> src/main/java: all OM specific sources (org.apache.woden.internal.om).
> By
> >> the way, I suggest that all OM related classes should be in the
> >> org.apache.woden.internal.om whereas now some of them are under
> >> org.apache.woden.
> >> src/test/java: sources for the OM tests
> >> src/test/resources: resources for the OM tests (WSDL, ...)
> >> resources/main/java: resources (schemas, ...)
> >> woden/java/woden-dom: directory for the Woden DOM Impl under which we
> find
> >> src/main/java: all DOM specific sources (org.apache.woden.internal.dom).
> >> By the way, I suggest that all DOM related classes should be in the
> >> org.apache.woden.internal.dom whereas now some of them are under
> >> org.apache.woden.
> >> src/test/java: sources for the DOM tests
> >> src/test/resources: resources for the DOM tests (WSDL, ...)
> >> resources/main/java: resources (schemas, ...)
> >> woden/java/woden-tool: directory for the Woden Tool under which we find
> >> src/main/java: Sources for the Converter.
> >> src/test/java: sources for the converter tests
> >> src/test/resources: resources for the converter tests (source WSDLs,
> >> expected WSDL)
> >> resources/main/java: resources (schemas, ...)
> >> woden/java/woden-ant: directory for the Woden Ant task under which we
> find
> >> src/main/java: Sources for the Ant task.
> >> I don't see the use of the eclipseplugin folder, maybe by the felix
> plugin
> >> ?
> >> I don't know what to do with the wsdl-view because I can't guess how it
> is
> >> used ? Maybe we need to put it into a separate module.
> >>
> >> The advantage of this layout is that we will keep the current JAR names
> >> (even if the content will be slightly different), the dependency between
> >> the POM will be removed (when I created a module for woden-tool, I need
> to
> >> modify the other POMs in order to excludes all converter related stuff,
> >> and the src and test directories will disappear.
> >> Any comments ?
> >> Jeff
> >>
> >>
> >> >
> >> >
> >> > thanks,
> >> > John.
> >> >
> >> > 2008/6/19 Jeff MAURY <[EMAIL PROTECTED]>:
> >> >>
> >> >> Hello,
> >> >>
> >> >> I have a simple question regarding the directory layout.
> >> >> As I am working on the converter, I have created a small test
> framework
> >> for the converter and added both classes and resources in the test
> >> directory.
> >> >> But it seems the converter is not yet compiled.
> >> >> In order to test the converter, should I create a new tool or
> converter
> >> module (like wooden-api, woden-om and wodem-dom). As there are lots of
> >> dependencies between the modules, and the POMs are not really maven
> >> compliant, shouldn't we start by refactoring the directory layout ?
> >> >>
> >> >> Thanks
> >> >> Jeff
> >> >>
> >> >>
> >> >> --
> >> >> La mélancolie c'est communiste
> >> >> Tout le monde y a droit de temps en temps
> >> >> La mélancolie n'est pas capitaliste
> >> >> C'est même gratuit pour les perdants
> >> >> La mélancolie c'est pacifiste
> >> >> On ne lui rentre jamais dedans
> >> >> La mélancolie oh tu sais ça existe
> >> >> Elle se prend même avec des gants
> >> >> La mélancolie c'est pour les syndicalistes
> >> >> Il faut juste sa carte de permanent
> >> >>
> >> >> Miossec (2006)
> >> >>
> >> >> http://www.jeffmaury.com
> >> >> http://riadiscuss.jeffmaury.com
> >> >> http://www.lastfm.fr/listen/user/jeffmaury/personal
> >>
> >>
> >>
> >> --
> >> La mélancolie c'est communiste
> >> Tout le monde y a droit de temps en temps
> >> La mélancolie n'est pas capitaliste
> >> C'est même gratuit pour les perdants
> >> La mélancolie c'est pacifiste
> >> On ne lui rentre jamais dedans
> >> La mélancolie oh tu sais ça existe
> >> Elle se prend même avec des gants
> >> La mélancolie c'est pour les syndicalistes
> >> Il faut juste sa carte de permanent
> >>
> >> Miossec (2006)
> >>
> >> http://www.jeffmaury.com
> >> http://riadiscuss.jeffmaury.com
> >> http://www.lastfm.fr/listen/user/jeffmaury/personal
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >
> >
> >
> > --
> > La mélancolie c'est communiste
> > Tout le monde y a droit de temps en temps
> > La mélancolie n'est pas capitaliste
> > C'est même gratuit pour les perdants
> > La mélancolie c'est pacifiste
> > On ne lui rentre jamais dedans
> > La mélancolie oh tu sais ça existe
> > Elle se prend même avec des gants
> > La mélancolie c'est pour les syndicalistes
> > Il faut juste sa carte de permanent
> >
> > Miossec (2006)
> >
> > http://www.jeffmaury.com
> > http://riadiscuss.jeffmaury.com
> > http://www.lastfm.fr/listen/user/jeffmaury/personal
>
>
> --
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


-- 
Saminda Abeyruwan

Senior Software Engineer
WSO2 Inc. - www.wso2.org

Reply via email to