I noticed that the package names for the 2 tools (converter and wsdl-viewer)
use different styles:

The converter package name under the java folder is
org.apache.woden.converter  (it used to be org.apache.woden.tool.converter)
The wsdl-viewer directory structure under the css and javascript folders is
org/apache/woden/tool/wsdl-viewer.

I don't mind dropping 'tool' from the package or directory path, as both
tools are now located under woden-tool, but should we make it consistent and
drop 'tool' from the wsdl-viewer directory structure too?

Also, is there a way to group the files under woden-tool to make it clearer
whether they are for the converter or wsdl-viewer, without breaking Maven
compliance?  At the moment all tools files are grouped by file type (css,
java, javascript, xslt) and you need to look into the sub-directory
structure or at the actual file names to work out which tool.

regards,
John.

On Mon, Aug 4, 2008 at 9:54 PM, John Kaputin (JIRA) <[EMAIL PROTECTED]> wrote:

>
>    [
> https://issues.apache.org/jira/browse/WODEN-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12619517#action_12619517]
>
> John Kaputin commented on WODEN-211:
> ------------------------------------
>
> I had to make a small code change to get the new woden source tree to
> compile in Eclipse. The declared package for the 2 converter classes was
> org.apache.woden.tool.converter, but under the new woden-tool/src/main/java
> directory the actual package name has been changed to
> org.apache.woden.converter (i.e. 'tool' has been dropped).   I changed the
> declared package in these 2 classes to match.   If this package name change
> was intentional, I can commit my change to the woden211/trunk branch and/or
> upload a patch.
>
> > Refactor directory layout to be more Maven compliant
> > ----------------------------------------------------
> >
> >                 Key: WODEN-211
> >                 URL: https://issues.apache.org/jira/browse/WODEN-211
> >             Project: Woden
> >          Issue Type: Improvement
> >            Reporter: Jeff MAURY
> >            Assignee: Jeremy Hughes
> >            Priority: Minor
> >         Attachments: trunk.zip
> >
> >
> > The directory layout should be refactored in order to follow Maven
> conventions. Today, there are dependencies between the Woden modules which
> miss flexibility.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

Reply via email to