Sure. I don't mind either way. I'll modify the formatter and check in at the places I mentioned.
Cheers, Jeremy 2008/8/22 Lawrence Mandel <[EMAIL PROTECTED]> > Thanks for creating an Eclipse formatter for the coding conventions. > > WRT the if statement, I'm prefer option 2 as I think it's easier to read. > > Lawrence > > > > > From: > "Jeremy Hughes" <[EMAIL PROTECTED]> > To: > woden-dev@ws.apache.org > Date: > 08/22/2008 06:33 AM > Subject: > Coding conventions in the Woden dev page > > > > Hi, I've applied the Woden conventions [1] to my eclipse 3.3. formatter. > The web page has a TODO: to export the guidelines ... which I've done and > attached the file to this email. We could store this in SVN: I was > thinking of this place in the current trunk: > > http://svn.apache.org/repos/asf/webservices/woden/trunk/java/ > > and this place in the woden211 branch > > > http://svn.apache.org/repos/asf/webservices/woden/branches/woden211/trunk/java/ > > > I'd like to propose we add the convention: keep simple 'if' on one line. > Which would mean this (e.g): > > if (thisExtendsSet.size() != otherExtendsSet.size()) return false; > > instead of > > if (thisExtendsSet.size() != otherExtendsSet.size()) > return false; > > (and I've included this convention in the attached file). > > I've managed to embody all the conventions described [1] in the eclipse > formatter file except for enforcing public/protocted javadoc'ing for > public APIs and javadoc'ing of public/protocted for internals. > > I don't think we should go and reformat all the woden code - but we could > start using the formatter rules for code added to existing source files > and of course new source files. > > What do you think? > > Jeremy > > [1] http://ws.apache.org/woden/dev/devprocess.html#Source+Code > > [attachment "woden-eclipse-formatter-conventions.xml" deleted by Lawrence > Mandel/Toronto/IBM] > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
