Yes, i have already done. Thanks,
On Tue, Oct 6, 2009 at 8:07 PM, Jeff MAURY <[email protected]> wrote: > > > On Tue, Oct 6, 2009 at 11:27 AM, Sagara Gunathunga > <[email protected]> wrote: >> >> On Tue, Oct 6, 2009 at 2:24 PM, Jeff MAURY <[email protected]> wrote: >> > 1) The purpose of the woden-tests main pom is to launch the tests so it >> > has >> > no sources files and its packaging is pom. So when you run install or >> > deploy >> > on it, it will install or deploy the pom only, this is coherent with >> > Maven >> > conventions. I don't think we should deploy the two generated JARS as >> > they >> > are almost empty (only an empty MANIFEST.MF file). >> >> I can agree with you, we don't need to deploy any empty JARs. >> Woden-commons deploys the test-jar file but other modules don't, this >> is an abnormal behavior. Either we should deploy test-jars for all >> the modules or should not deploy any . But with above change we don't >> need to deploy any test-jars. >> >> >> > 2) Regarding the woden-commons, I don't remember exactly but it seems >> > only >> > the test resources are used by woden-commons but they may also be used >> > by >> > the test that it in wodem-commons. So if you move these resources to >> > woden-tests, the test in woden-commons may fail. >> > >> >> I have only moved TestErrorHandler class into the woden-test module >> because that's the only required class for woden-test test cases . >> This will eliminate the use of woden-commons-test .jar . I already >> build all the modules successfully with this modification. > > In that case, you can remove the build of woden-commons-test.jar so that it > will not be installed and deployed anymore. > > Jeff > >> >> >> Thanks, >> >> >> >> > Regards >> > Jeff >> > >> > On Thu, Sep 24, 2009 at 2:21 PM, Sagara Gunathunga >> > <[email protected]> wrote: >> >> >> >> Hi Jeff , >> >> >> >> Do you have any suggestions related to following two issues ? >> >> >> >> 1.) In Woden-test module by running Maven install goal doesn't >> >> install any Jar files on Maven repository it just generate two jar >> >> files in the target directory . In the same way deploy goal doesn't >> >> deploy any jar files in to repo too. But we should install this >> >> artifact in to repo with install goal ? ( can be as two jars or one >> >> jar file) >> >> >> >> 2.) Woden-commons module generate another test jar file to support >> >> woden-test module that package the common test classes. By looking at >> >> that module I realized only two common test classes there ,cant we >> >> move these two classes in to woden-test module so that we don't need >> >> to have Woden-commons-test.jar dependency ? >> >> >> >> Thanks , >> >> >> >> On Tue, Sep 22, 2009 at 10:22 PM, Sagara Gunathunga >> >> <[email protected]> wrote: >> >> > Hi Jeremy, >> >> > >> >> > Thanks for pointing out those facts,I'm also felt strange at first >> >> > time but after looking at the each of the POM file i came up with >> >> > following reasons for this behavior. >> >> > >> >> > >> >> >> Did you mean to publish woden-tests - there isn't a jar in >> >> >> there. >> >> > >> >> > According to Woden-test module POM file, it invoke test cases using >> >> > maven-invoker-plugin and packaging is defined as pom ( >> >> > <packaging>pom</packaging> ) so there is no Jar package here. >> >> > >> >> > But I'm also think Woden-test.jar file should be there because non of >> >> > above jar files contain DOM/OM specific test classes. >> >> > >> >> > >> >> > Also, the woden-impl-commons has a snapshot jar of tests. Just >> >> >> felt strange that the others didn't have test jars. >> >> >> >> >> > >> >> > woden-impl-commons POM file contains following comment. >> >> > >> >> > "this POM contains test resources shared by the OM, DOM and tests >> >> > POMs. This configuration will generate a JAR for the test resources >> >> > so >> >> > that they can be used by these POMs. See >> >> > http://tildemh.com/2007/12/19/maven2-unit-test-dependencies " >> >> > >> >> > >> >> > I haven't change this behavior and kept Jeff MAURY's original >> >> > refracting design as it is. BTW it would be great if Jeff can >> >> > clarify >> >> > about this behavior in detail. >> >> > >> >> > >> >> > >> >> >> 2009/9/22 Sagara Gunathunga <[email protected]>: >> >> >>> Hi Jeremy , >> >> >>> >> >> >>> After configuring some of the SSH settings it worked for me ! I >> >> >>> have >> >> >>> uploaded new snapshots today [1] >> >> >>> >> >> >>> [1] - http://people.apache.org/repo/m2-snapshot-repository >> >> >>> >> >> >>> >> >> >>> Thanks >> >> >>> >> >> >>> On Tue, Sep 22, 2009 at 2:20 AM, Jeremy Hughes <[email protected]> >> >> >>> wrote: >> >> >>>> Hi ... >> >> >>>> >> >> >>>> 2009/9/21 Sagara Gunathunga <[email protected]>: >> >> >>>>> Hi Jeremy , >> >> >>>>> >> >> >>>>> AFAIK to run "mvn deploy" and to upload artifacts i should add >> >> >>>>> server definition in my local settings.xml something similar to >> >> >>>>> following one [1]. >> >> >>>>> >> >> >>>>> <server> >> >> >>>>> <id>internal.repo</id> >> >> >>>>> <username>maven</username> >> >> >>>>> <password>foobar</password> >> >> >>>>> </server> >> >> >>>>> >> >> >>>>> i just tired with my shell user name /password but it failed. >> >> >>>> >> >> >>>> hmm, this should work. Are you using your id/password that you can >> >> >>>> ssh >> >> >>>> into people.apache.org with? >> >> >>>> >> >> >>>>> >> >> >>>>> >> >> >>>>> I'm wonder how can i find those details or who can really upload >> >> >>>>> to >> >> >>>>> snapshot repository ? >> >> >>>>> >> >> >>>>> I don't think those credentials not publicly available if so any >> >> >>>>> one >> >> >>>>> can update the repository >> >> >>>>> >> >> >>>>> [1] - >> >> >>>>> http://maven.apache.org/plugins/maven-deploy-plugin/usage.html >> >> >>>> >> >> >>>> >> >> >>>> --------------------------------------------------------------------- >> >> >>>> To unsubscribe, e-mail: [email protected] >> >> >>>> For additional commands, e-mail: [email protected] >> >> >>>> >> >> >>>> >> >> >>> >> >> >>> >> >> >>> >> >> >>> -- >> >> >>> Sagara Gunathunga >> >> >>> >> >> >>> Blog - http://ssagara.blogspot.com >> >> >>> Web - http://people.apache.org/~sagara/ >> >> >>> >> >> >>> >> >> >>> --------------------------------------------------------------------- >> >> >>> To unsubscribe, e-mail: [email protected] >> >> >>> For additional commands, e-mail: [email protected] >> >> >>> >> >> >>> >> >> >> >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: [email protected] >> >> >> For additional commands, e-mail: [email protected] >> >> >> >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Sagara Gunathunga >> >> > >> >> > Blog - http://ssagara.blogspot.com >> >> > Web - http://people.apache.org/~sagara/ >> >> > >> >> >> >> >> >> >> >> -- >> >> Sagara Gunathunga >> >> >> >> Blog - http://ssagara.blogspot.com >> >> Web - http://people.apache.org/~sagara/ >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: [email protected] >> >> For additional commands, e-mail: [email protected] >> >> >> > >> > >> > >> > -- >> > http://www.jeffmaury.com >> > http://riadiscuss.jeffmaury.com >> > http://www.lastfm.fr/listen/user/jeffmaury/personal >> > >> >> >> >> -- >> Sagara Gunathunga >> >> Blog - http://ssagara.blogspot.com >> Web - http://people.apache.org/~sagara/ > > > > -- > http://www.jeffmaury.com > http://riadiscuss.jeffmaury.com > http://www.lastfm.fr/listen/user/jeffmaury/personal > -- Sagara Gunathunga Blog - http://ssagara.blogspot.com Web - http://people.apache.org/~sagara/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
