2009/11/27 <[email protected]>:
> Author: scottbw
> Date: Fri Nov 27 10:25:01 2009
> New Revision: 884822
>
> URL: http://svn.apache.org/viewvc?rev=884822&view=rev
> Log:
> Added meaningful error log messages
...
> + } catch (IOException e) {
> + _logger.error("Hot
> deploy error: Unable to move dropped .wgt file to upload folder");
We need to provide more user friendly feedback in the sense of having
a console in the interface to report why the deployed widget is not
present. Probably the simplest thing to do at this stage is to have a
page that will show reported errors from the log. Having an error
silently swallowed like this will result in a maintenance problem.
> + } catch
> (BadWidgetZipFileException e) {
> + _logger.warn("Hot
> deploy error: file is not a valid widget packge");
Surely if the Zip is bad it is an error and should be handled as above?
> + } catch (BadManifestException
> e) {
> + _logger.warn("Hot
> deploy error: widget has invalid manifest");
Ditto.
This is a vast improvement in that the logs will have meaningful
messages, but it doesn't address my concerns about silently swallowing
exceptions.
It does mean that we might be able to figure our what the errors are
that are reported when the patch on ISSUE-51 is applied - so thanks
for that.
Ross
