On Sat, Sep 06, 2025 at 01:27:04PM +0200, Greg KH wrote: > > Obviously, we don't want to use the cover letter as-is, which is why b4 will > > open the configured editor to let the maintainer pulling in the series make > > any changes to the cover letter before it becomes the merge commit. > > I like this a lot, and just tried it, but it ends up applying the > patches from the list without my signed-off-by, which will cause > linux-next to complain when it sees that I committed patches without > that. > > Did I miss an option to `b4 shazam`? Does it need to add a -s option > like `b4 am` has?
Yes, most of the time you'll want to run it as `b4 shazam -Ms`. Unfortunately, `shazam -M` is not perfect, because we do need to know the base-commit, and there's still way too many series sent without this info. We do some magic trying to figure out where the series might belong (basically, by comparing blob hashes and trying to find the tree with the same set of blob hashes as in the patch), but it only works if you have the same local repo as the contributor. Best regards, -K
