Kurosu a écrit : > Miguel Cruz a écrit : > >> Hello! >> >> Sorry for forget script, this is the script: >> (attach file from this mail or download for): >> >> http://www.4shared.com/file/77338582/ba04bcbc/wormuxBonusPack.html >> > > OK, I have check the NSIS script and confirm the following things: > 1) installs in a guessed directory, which would be the install folder > This is not the best, considering the install could be somewhere else, > or it may require administrator rights. I haven't checked if the > personal map folder fully works though. >
Personal map folder fully works under Linux (I'm using it), so I guess it works for Windows too. To my mind, this is bad to install those maps in a guessed directory. > Anyway, if wormux is not installed, the additional maps installer would > better abort. > If it tries to install maps in wormux install directory, it *must* abort if not installed. > 2) no uninstall as far as I see > Not a bad thing considering the wormux installer removes the whole > install folder, and this installer puts the files there. > > For the time being, it could be good enough. > I'm not so sure :-/ To my mind, ideally, the installer should offer the choice between : - installing in the wormux installation folder. That means detecting wormux install path, abort if wormux is not installed, checking the right correctly to abort with a right message if rights aren't enough. - installation in personal directory. Not sure we need an uninstall feature. > Miguel, if you want to improve your script, you could check the svn here: > http://svn.gna.org/viewcvs/wormux/trunk/build/win32_setup/ > and see how the NSIS code embedded in the create_setup.sh manages rights > and retrieving the install folder if it exists. > > Best regards, > Kurosu > Regards, Matt (gentildemon) _______________________________________________ Wormux-update mailing list [email protected] https://mail.gna.org/listinfo/wormux-update
