Mike, Right you are. My mistake was testing with a theme that used `add_theme_support()` elsewhere in the page. This bug does exist.
On Sun, Jan 2, 2011 at 7:01 AM, <[email protected]> wrote: > Rich and Eric, > > I can confirm this in 3.1-RC2. I was able to register the post_formats > "banana" and "taco" assign them to posts and even have the slug display > via get_post_format(). The radio buttons appear, but have no label. Here's > my code: > > add_theme_support( 'post-formats', array( 'banana', 'aside', 'audio', > 'chat', 'status', 'image', 'gallery', 'quote', 'taco' ) ); > > -Mike > > > Rich, > > > > I can't reproduce this with the latest nightly. Can you re-confirm > you're > > seeing this and also link to the build number you're testing against? > > > > On Sun, Jan 2, 2011 at 5:41 AM, Rich Pedley <[email protected]> wrote: > > > >> If you add theme support for an unknown post-format it appears on the > >> edit > >> screen, but with a blank label. As extra ones were not supposed to be > >> allowed then surely this is a mistake. > >> > >> So if I test with the following: > >> > >> add_theme_support( 'post-formats', array( 'aside', 'gallery','bug' ) ); > >> > >> I actually see, 4 radio buttons and 3 labels: Standard, Aside, Gallery. > >> the > >> 4th label markup is there, but with no visible text. > >> > >> > >> Adding in a check to see if get_post_format_string( $format ) isn't > >> blank > >> would fix this, but that seems an awkward solution. > >> > >> So I'm guessing that a check needs to be done after line 245 of > >> meta-boxes.php > >> $post_formats = get_theme_support( 'post-formats' ); > >> > >> to check the array against the allowed get_post_format_strings. > >> > >> Rich > >> _______________________________________________ > >> wp-testers mailing list > >> [email protected] > >> http://lists.automattic.com/mailman/listinfo/wp-testers > >> > > _______________________________________________ > > wp-testers mailing list > > [email protected] > > http://lists.automattic.com/mailman/listinfo/wp-testers > > > > > _______________________________________________ > wp-testers mailing list > [email protected] > http://lists.automattic.com/mailman/listinfo/wp-testers > _______________________________________________ wp-testers mailing list [email protected] http://lists.automattic.com/mailman/listinfo/wp-testers
