Thank you for adding this patch to the 2.6.1 source code!
alex K6LOT
> Begin forwarded message:
>
> Hi there,
>
> I was hoping we could incorporate this patch into the official builds. It’s
> really only needed for Mac when building against the MacOS 13 SDK.
> However it’s just an easy fix that prevents a possible buffer overrun.
> Here’s the patch:
>
> diff --git a/widgets/mainwindow.cpp b/widgets/mainwindow.cpp
> index 11d82d18a..5c3d8cd95 100644
> --- a/widgets/mainwindow.cpp
> +++ b/widgets/mainwindow.cpp
> @@ -4817,9 +4817,9 @@ void MainWindow::guiUpdate()
> if(m_transmitting) {
> char s[42];
> if(SpecOp::FOX==m_specOp and ui->tabWidget->currentIndex()==1) {
> - sprintf(s,"Tx: %d Slots",foxcom_.nslots);
> + snprintf(s,sizeof(s),"Tx: %d Slots",foxcom_.nslots);
> } else {
> - sprintf(s,"Tx: %s",msgsent);
> + snprintf(s,sizeof(s),"Tx: %s",msgsent);
> }
> m_nsendingsh=0;
> if(s[4]==64) m_nsendingsh=1;
>
> Thanks for considering this patch- or please let me know how to file a pull
> request.
>
> alex K6LOT
_______________________________________________
wsjt-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
