Nick, I have added a comment to the first one. In the future, it will be helpful if you can following the PMC review process and fill in the PMC approval template in https://wiki.eclipse.org/WTP_PMC_Defect_Review to help PMC to understand the impact for approval.
Thanks, Elson ----------------------------------------------------------------- Elson Yuen, P.Eng. WebSphere Server Tools and Bluemix Tools Architect IBM Toronto Lab Tel: (905) 413-2689, T/L: 313-2689 From: Nick Boldt <nbo...@redhat.com> To: Shane Clarke <shane.cla...@outlook.com>, "General discussion of project-wide or architectural issues." <wtp-dev@eclipse.org> Cc: Keith Chong <kch...@ca.ibm.com>, Mat Booth <mat.bo...@redhat.com> Date: 2018/05/31 09:38 AM Subject: [wtp-dev] URGENT - Please review TODAY (was Re: gerrit review for JAXWS bugzilla) Sent by: wtp-dev-boun...@eclipse.org Adding PMC to cc: so they're aware of the need for a +1. I've added the usual suspects to the first BZ - the second already has Elson's +1 so I assume we're good there as generally everyone else just ignores these things. :) https://bugs.eclipse.org/bugs/show_bug.cgi?id=534747 https://bugs.eclipse.org/bugs/show_bug.cgi?id=265772 As TODAY is the usual day for spinning up a build for smoke test (so people have Fri & Mon to review prior to the Tuesday deadline), this is somewhat urgent. On Thu, May 31, 2018 at 2:47 AM, Shane Clarke <shane.cla...@outlook.com> wrote: Hi Guys, Sorry for being late with getting to this. For https://git.eclipse.org/r/#/c/122761/ if we can get the PMC votes for RC3 i'll get it in. And for https://git.eclipse.org/r/#/c/122932/ i think Keith should sign off on it if possible. Thanks, Shane From: Nick Boldt <nbo...@redhat.com> Sent: Wednesday 30 May 2018 14:18 To: Mat Booth Cc: Shane Clarke; Keith Chong Subject: Re: gerrit review for JAXWS bugzilla I've merged the fix for parent pom and rebuilt it. https://hudson.eclipse.org/webtools/job/webtools-webservices-gerrit_master/ will trigger once the current wtp common build is done (it's rebuilding because of the parent pom change). On Wed, May 30, 2018 at 8:19 AM, Mat Booth <mat.bo...@redhat.com> wrote: Another update -- My Orbit fix is now available in an I-build, so I submitted the following change for the wtp-parent to update its orbit repo reference: https://git.eclipse.org/r/#/c/123635/ If that is merged, then jenkins should be able to do a successful build of this change: https://git.eclipse.org/r/#/c/122932/ On 23 May 2018 at 10:45, Mat Booth <mat.bo...@redhat.com> wrote: Regarding this second change, my fix for Orbit was merged, and the new wsil4j bundle is available from the latest Orbit nightly repo: http://download.eclipse.org/tools/orbit/N-builds/N20180522205425/ On 19 May 2018 at 01:18, Nick Boldt <nbo...@redhat.com> wrote: There's also a second gerrit for review here [1] but that requires a fix in Orbit [2] first. [1] https://git.eclipse.org/r/#/c/122932/ [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=534859 So... I guess that will require the post-RC1 PMC approval process. On Fri, May 18, 2018 at 9:06 AM, Nick Boldt <nbo...@redhat.com> wrote: Please have a look and if you approve, merge this: https://git.eclipse.org/r/#/c/122761/ > Bug 534747 - Use import-package for deps that can be supplied by the jre This makes WTP more compatible with other platforms (like linux) where Eclipse can be installed via rpm. Hopefully the Jenkins on which the gerrit is building won't crap out like the ones the other day. Seems ci.eclipse.org is a bit overloaded these days. Must be RC season. :) Nick -- Nick Boldt Principal Software Engineer, RHCSA Productization Lead :: JBoss Tools & Dev Studio IM: @nickboldt / @nboldt / http://nick.divbyzero.com TRIED. TESTED. TRUSTED. @ @redhatnews Red Hat “The Only Thing That Is Constant Is Change” - Heraclitus -- Nick Boldt Principal Software Engineer, RHCSA Productization Lead :: JBoss Tools & Dev Studio IM: @nickboldt / @nboldt / http://nick.divbyzero.com TRIED. TESTED. TRUSTED. @ @redhatnews Red Hat “The Only Thing That Is Constant Is Change” - Heraclitus -- Nick Boldt Principal Software Engineer, RHCSA Productization Lead :: JBoss Tools & Dev Studio IM: @nickboldt / @nboldt / http://nick.divbyzero.com TRIED. TESTED. TRUSTED. @ @redhatnews Red Hat “The Only Thing That Is Constant Is Change” - Heraclitus -- Nick Boldt Principal Software Engineer, RHCSA Productization Lead :: JBoss Tools & Dev Studio IM: @nickboldt / @nboldt / http://nick.divbyzero.com TRIED. TESTED. TRUSTED. @ @redhatnews Red Hat “The Only Thing That Is Constant Is Change” - Heraclitus _______________________________________________ wtp-dev mailing list wtp-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wtp-dev
_______________________________________________ wtp-dev mailing list wtp-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/wtp-dev