Just realised that the show_all_objects method was not in a test, but from actual lib. This means that it will stay as it is currently. Gonna merge Željko-s changes in. Thanks!
Jarmo On Wed, Sep 29, 2010 at 8:16 PM, Jarmo <[email protected]> wrote: > Željko, i'm making the changes myself so don't worry about it. > > Jarmo > > On Wed, Sep 29, 2010 at 8:12 PM, Jarmo <[email protected]> wrote: >> Željko, everything else seemed reasonable and understandable to me, >> but why this boolean parameter at show_all_objects(output = true)? I'd >> recommend to remove it and also remove the if-statement in there. It >> doesn't add any additional value to the test. If there's some need to >> get more information in the test then plain old debugger will do the >> trick ;) >> >> Jarmo >> >> On Wed, Sep 29, 2010 at 8:08 PM, Jarmo <[email protected]> wrote: >>> Just pushed my changes which allowed for me to run tests within gems. >>> >>> I tried to install those gems locally and then ran tests from Watir >>> and FireWatir. For FireWatir i deleted locally these attach tests >>> because i wasn't able to run them (even without my changes). >>> >>> Results for Watir: >>> 311 tests, 1467 assertions, 0 failures, 0 errors >>> >>> for FireWatir: >>> 314 tests, 1667 assertions, 0 failures, 0 errors >>> >>> It would be great if someone pulled changes from master and installed >>> gems locally and tried to run tests from the gems. Use "rake test" >>> task for that :) >>> >>> I'm not gonna move CI code before 1.6.6 - will clean that up later. >>> >>> I'm gonna take a look at Željko-s changes. >>> >>> Jarmo >>> >>> On Wed, Sep 29, 2010 at 5:55 PM, Bret Pettichord <[email protected]> >>> wrote: >>>> Yes, i think it is time to release. >>>> >>>> On Wed, Sep 29, 2010 at 9:31 AM, Charley Baker <[email protected]> >>>> wrote: >>>>> >>>>> Agree with Jarmo, we'll take a look for 1.6.7 shortly. I'm not seeing >>>>> any reports for people using 1.6.6 yet which is rather disappointing, >>>>> but perhaps that means it's about time to release? Thoughts? >>>>> >>>>> -c >>>>> >>>>> >>>>> On Wed, Sep 29, 2010 at 8:18 AM, Jarmo <[email protected]> wrote: >>>>> > I noticed these. I have a recommendation not to pull anything before >>>>> > 1.6.6 is out. >>>>> > >>>>> > Jarmo >>>>> > >>>>> > On Wed, Sep 29, 2010 at 5:12 PM, Bret Pettichord <[email protected]> >>>>> > wrote: >>>>> >> FYI >>>>> >> >>>>> >> ---------- Forwarded message ---------- >>>>> >> From: GitHub <[email protected]> >>>>> >> Date: Tue, Sep 28, 2010 at 7:10 PM >>>>> >> Subject: [GitHub] Build fixes and attribute fixes [bret/watir GH-1] >>>>> >> To: [email protected] >>>>> >> >>>>> >> >>>>> >> alanshields wants someone to pull from >>>>> >> alanshields:build_fixes_and_attribute_fixes: >>>>> >> >>>>> >> Please find enclosed a set of patches to: >>>>> >> >>>>> >> - Enable building on UNIX >>>>> >> - Correctly handle .attribute_value('foo-bar') >>>>> >> - Not throw an exception when an element like <div></div> is checked >>>>> >> for >>>>> >> containing text >>>>> >> >>>>> >> Thank you very much for all your work on FireWatir! >>>>> >> Alan Shields >>>>> >> >>>>> >> View Pull Request: http://github.com/bret/watir/pull/1 >>>>> >> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> Bret Pettichord >>>>> >> Lead Developer, Watir, www.watir.com >>>>> >> >>>>> >> Blog, www.io.com/~wazmo/blog >>>>> >> Twitter, www.twitter.com/bpettichord >>>>> >> >>>>> >> >>>>> >> _______________________________________________ >>>>> >> Wtr-development mailing list >>>>> >> [email protected] >>>>> >> http://rubyforge.org/mailman/listinfo/wtr-development >>>>> >> >>>>> > _______________________________________________ >>>>> > Wtr-development mailing list >>>>> > [email protected] >>>>> > http://rubyforge.org/mailman/listinfo/wtr-development >>>>> > >>>>> _______________________________________________ >>>>> Wtr-development mailing list >>>>> [email protected] >>>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>>> >>>> >>>> -- >>>> Bret Pettichord >>>> Lead Developer, Watir, www.watir.com >>>> >>>> Blog, www.io.com/~wazmo/blog >>>> Twitter, www.twitter.com/bpettichord >>>> >>>> >>>> _______________________________________________ >>>> Wtr-development mailing list >>>> [email protected] >>>> http://rubyforge.org/mailman/listinfo/wtr-development >>>> >>> >> > _______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
