Hey Zeljko,
On Thu, Sep 30, 2010 at 7:04 AM, Željko Filipin <[email protected]> wrote: > Hi, > > I started playing with Watir code, unit tests to be more precise, and I have > a few questions: > > 1) Is there a way to run *all* watir/firewatir unit tests? I am looking at > the code and as far as I get it, only some tests are run with all_tests.rb. > After I make the change I would like to test if I broke something. Should > tests that are not run with all_tests.rb even be considered as good tests? I'll admit I've mostly been using core for watir and then all tests for firewatir. I just ran the non core tests for watir - xpath tests seems to be working fine, so we might as well add those back in unless there's a reason not to. The must be visible tests are failing, they're somewhat flaky and obviously didn't run in CI when that was set up. Worth taking a closer look. > > 2) Can I remove this from ruby and html files in tests? > > ruby: > # revision: $Revision$ > > html: > CVS Revision: "$Revision$" Yep, that's old stuff. > > 3) When I open watir/unittests/div_test.rb for example, NetBeans complains > that assert_raises will be deprecated in ruby 1.9, assert_raise should be > used. More information: > http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/155815 > > Should I make the change? > I suggest we don't make this change. Minitest for 1.9.x supports assert_raises and there are some other threads that I was reading through where there was some argument about whether to deprecate this or not. For the time being, I vote that we leave it. > 4) Why are tests for div, span and p all in div_test.rb? Should I split it > into three files? Good question, certainly more non_control type tests than specifically divs, although there are specific files for other non control types. I don't see any harm in splitting them out. > > Željko > > _______________________________________________ > Wtr-development mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/wtr-development > _______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
