So I've spent some time today pulling apart the modal_dialog_suite, and
testing against 1.8.7

Surprisingly, most of it works bar 2 exceptions ...

assert_no_modals in test_modal_dialog_use_case_default appears to be an
undefined local variable or method

I also can't click on a button modal1.button(:text, 'Another
Modal').click_no_wait in test_double_modal however the element exists and
can be found in irb etc. The click_no_wait doesn't appear to launch the 2nd
modal.

When you say Win32OLE is patched/hacked, is that the shared object in
C:\ruby187\lib\ruby\1.8\i386-mingw32
or
C:\ruby187\lib\ruby\gems\1.8\gems\watir-1.7.0\lib\watir\win32ole.rb OR
win32ole\win32ole.so ?

If win32ole is the only thing holding us back, why don't we crack on with
the ming compiled version and ditch 1.8.6 altogether?

Cheers,
Tim


On Tue, Jan 11, 2011 at 1:39 PM, Bret Pettichord <[email protected]>wrote:

> Charley's comment and a discussion with Hugh McGowan at work have reminded
> me of the state of this.
>
> 1. We actually swap in our own copy of the Ruby Win32OLE library. This is C
> code and therefore needs to be compiled using the same compiler as Ruby. The
> version currently distributed with watir works with early versions of 1.8.6.
> I think they changed to the new compiler (ming) in the most recent versions
> of 1.8.6.
>
> 2. This whole approach is incredibly hacky (it was my idea). I have
> previously suggested that we pull this code (the showModalDialog support
> only) into a separate gem simply because it does these horrible things and
> adds these dependencies that really don't matter to many Watir users.
>
> 3. I was a bit confused, because I know we have some people using 1.8.7 at
> Convio, but apparently this is because Hugh hacked the version of Win32Ole
> to make it work.
>
> 4. Yes, Jarmo that is "the" modal dialog test.
>
> Bret
>
> On Mon, Jan 10, 2011 at 11:54 AM, Jarmo <[email protected]> wrote:
>
>> On Mon, Jan 10, 2011 at 5:39 PM, Tim Koopmans <[email protected]>wrote:
>>
>>> I've recommended 1.8.6 or 1.8.7 of Ruby but thinking of cutting this back
>>> to 1.8.7, pending IE modal dialog support (is there a specific unit test for
>>> that?)
>>>
>>
>> I found something at unittests\windows\modal_dialog_test.rb. I'm not sure
>> if that is THE modal dialog, but it seems to be. For me that test blocks
>> forever under Win7/XP with 1.8.6 and 1.8.7. Haven't had any time to
>> investigate as to why is that happening. Maybe someone else can try that
>> test on their machine too to see if there's any difference and maybe even
>> figure out the problem itself.
>>
>> Jarmo
>>
>> _______________________________________________
>> Wtr-development mailing list
>> [email protected]
>> http://rubyforge.org/mailman/listinfo/wtr-development
>>
>
>
>
> --
> Bret Pettichord
> Director, Watir Project, www.watir.com
>
> Blog, www.testingwithvision.com
> Twitter, www.twitter.com/bpettichord
>
>
> _______________________________________________
> Wtr-development mailing list
> [email protected]
> http://rubyforge.org/mailman/listinfo/wtr-development
>
_______________________________________________
Wtr-development mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/wtr-development

Reply via email to